Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp253985ybi; Wed, 29 May 2019 20:43:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcgz3tSjzrRw/3MDCQ402GHy03Nc+JeOKdZ5znTkVdqgTCqsdzYb1TGvSneaFrByifdxSt X-Received: by 2002:a17:902:9f8b:: with SMTP id g11mr1706074plq.199.1559187818963; Wed, 29 May 2019 20:43:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559187818; cv=none; d=google.com; s=arc-20160816; b=1K/MLw1e45tk1exfrP3suUA6W6YK1chmLmkSvqvi+2OSwR5zvgP01cJfTmKCVe5N8i 8BXJp6bZJH/slk6IxXWoQ/P+uSWzKYFHy/Gpy8MoypuQmqj6x29tjCFURV4lZJnUI1ae Hjl4JGYvJbbjBd3Rvd6MDCXyBxf7YqCxJx8N6uKWvqxStqheCZ2L2/1T1U6svvIGcpu+ +NKVsEsOYraxfwUV3Faf9anl1Sq4QTPCq+M5WYUUxx7dN4T+mFOXUvT88Mdtcl1UT0im E5SyeZWIwzCCsxbeYKFCxd3uoBMPColCDjhGiCPrGzTm7knNt9Hx1eo3vOLW6Af2zELG MN1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b/acGKKmYTe5jdgSWPwcMZCV9+LmgOAl745C811IUcI=; b=fclcRhqRD5HKEQAyhIMeyU4EUCtoL5A3FGAPW89ai/ClvwzEXJofVsRp3/05Smhlu/ MOKk32N2fUIfHbIxdt+eADr87Y3P1TBdT9toSsPijWHZl6kdvhQjDxuy/dOEoA2M4CYX /MZw5zJo4sfPu0C5D/XPuNY9AkXeE+KA7zfsEv989yrnr2yUa6I50cD6Y6xte2Y2ha4X F8qr+QvACk7OaL7Du5MnSV7zExY5OXwBrhaFrsDRx8lwGbwVhJiUcmmZ3tBaoxs/ZxrK DUjQJwX1jDjCVUtRgHufc/8G/I690K26dNDzx++UDA+VgAvX8yvS4pLdA30DFaD79XqK rDKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xWECkO40; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i67si2087271pfb.124.2019.05.29.20.43.22; Wed, 29 May 2019 20:43:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xWECkO40; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732657AbfE3DlW (ORCPT + 99 others); Wed, 29 May 2019 23:41:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:34356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732526AbfE3DVV (ORCPT ); Wed, 29 May 2019 23:21:21 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28DEB248FC; Thu, 30 May 2019 03:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186480; bh=eLnA3TCUZw3mt9N2WqAhU+mxgcnznVC7qAxRzjMRZv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xWECkO40a9SGJb880MbdY39kIjo2QJRnVvWRvLBvw2tynECUTs2WHD0V6xMdOjW0U Xxbl3u8R5UhvD7g7acHUgNmxdKNRsKwRlyEGbXMprOPVDaJsT4m9Xlew0iXeVPbhtM xy3Aj5NigvlnZih0REUBIOiHtd6H2rKvLL8dMLrc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Alan Stern , Sasha Levin Subject: [PATCH 4.9 116/128] usb: core: Add PM runtime calls to usb_hcd_platform_shutdown Date: Wed, 29 May 2019 20:07:28 -0700 Message-Id: <20190530030455.379251731@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030432.977908967@linuxfoundation.org> References: <20190530030432.977908967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 8ead7e817224d7832fe51a19783cb8fcadc79467 ] If ohci-platform is runtime suspended, we can currently get an "imprecise external abort" on reboot with ohci-platform loaded when PM runtime is implemented for the SoC. Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown. Signed-off-by: Tony Lindgren Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/core/hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index bdb0d7a08ff9b..1dd4c65e9188a 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -3033,6 +3033,9 @@ usb_hcd_platform_shutdown(struct platform_device *dev) { struct usb_hcd *hcd = platform_get_drvdata(dev); + /* No need for pm_runtime_put(), we're shutting down */ + pm_runtime_get_sync(&dev->dev); + if (hcd->driver->shutdown) hcd->driver->shutdown(hcd); } -- 2.20.1