Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp255275ybi; Wed, 29 May 2019 20:45:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnUj0TPIH7IRYBy8br0MkckHWtlV69mH3Qw+0GXsw5vN5YhuPRhFcwIKID5QW+uviytQ3B X-Received: by 2002:a17:90a:21ce:: with SMTP id q72mr1395854pjc.3.1559187920450; Wed, 29 May 2019 20:45:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559187920; cv=none; d=google.com; s=arc-20160816; b=ICyS81zlflzA+S+bYKGGtQ498pBo3kblsxFsIwpRntfSS5bwUFTDdn6biVc80wMN8c UVqwOP3a/NEgOWnRSXHKmgNOZWuE2OKz/lvHyCKbiUH1cTyeGRWmgDrbMFStkKAduWrF wbOfg1uMkAokeGbZ4TudK8yzUqtR2pDLJIBO21VPPRpyzGOZWdp2rmxmtFjYTg7wTowA wrn0/fpyElLFL9RhY8Ge9N9wFRoQq30ZUfBsoig2zbUC2YRx4EjLFXsoSKe0R7g1Zthb wM6yjYvtspwTTFNptkCmE07hzsfF5sMh/p5JmnQajmQL2uOGp/lUKpDEc5Z4x6TvZLdD oqmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QMIGLiVE5xLvt7fap8f6nB9Zf1wbL8R8Z5N8TnpSs9s=; b=zIJDEM2szMD6dv2DPppelsBnhzviS0L9C/Gb0d9KRTxGBZXJCRrR/1qD2c0x4OrFu9 UrTCFkFsutY1isioi6l+VD8YoCkzZK1KPmwq/vqNBxnK85/Br4Tjr+K2nXp0uHw62dXP d7NkRPFrnPBRMZ23lB/h87z0U2+jDvt7KJC1W9H/ZU3fKAMKJ3LDIsSTe10Hxk8Xo297 RcsxwTLe02xxL4ewBkZM5hFn4ucfvGlGugcfjKclyGP6kxZQBqnhUwvjga7Xrwqk8yYT ZcmFdQ0Ol18cXt82j9ARRnFWigZa/uGH+tTTOlzUlHWGW4Sakw4LtDnCQlfVjP+WV+/Z jgIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GqOkuGKg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s2si1914196pgg.225.2019.05.29.20.45.03; Wed, 29 May 2019 20:45:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GqOkuGKg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732439AbfE3Dm6 (ORCPT + 99 others); Wed, 29 May 2019 23:42:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:60994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730621AbfE3DVE (ORCPT ); Wed, 29 May 2019 23:21:04 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66CFA2496D; Thu, 30 May 2019 03:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186464; bh=5yfE+PIdwBJEYMQT2JIinYrvyYeU/jnxN8az01WPZ08=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GqOkuGKgWcd9gZ6MR3H4Uo5/gzSwSF8H9i6383J2JpGJSBJq6naRjMj6Dsv7widCG zxIiIlS97mMJZBZ+/g6ijsgdMIKwzNeqo+eOgOUluTvEuRyY3TeoebdBUmgjXIaBCA YHqnPKMt3zPhsAw9QG1Nop+4NCIWAzyOp5f3hCm0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Baluta , Nicolin Chen , Mark Brown , Sasha Levin Subject: [PATCH 4.9 042/128] ASoC: fsl_sai: Update is_slave_mode with correct value Date: Wed, 29 May 2019 20:06:14 -0700 Message-Id: <20190530030441.786039033@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030432.977908967@linuxfoundation.org> References: <20190530030432.977908967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit ddb351145a967ee791a0fb0156852ec2fcb746ba ] is_slave_mode defaults to false because sai structure that contains it is kzalloc'ed. Anyhow, if we decide to set the following configuration SAI slave -> SAI master, is_slave_mode will remain set on true although SAI being master it should be set to false. Fix this by updating is_slave_mode for each call of fsl_sai_set_dai_fmt. Signed-off-by: Daniel Baluta Acked-by: Nicolin Chen Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_sai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 9fadf7e31c5f8..cb43f57f978b1 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -274,12 +274,14 @@ static int fsl_sai_set_dai_fmt_tr(struct snd_soc_dai *cpu_dai, case SND_SOC_DAIFMT_CBS_CFS: val_cr2 |= FSL_SAI_CR2_BCD_MSTR; val_cr4 |= FSL_SAI_CR4_FSD_MSTR; + sai->is_slave_mode = false; break; case SND_SOC_DAIFMT_CBM_CFM: sai->is_slave_mode = true; break; case SND_SOC_DAIFMT_CBS_CFM: val_cr2 |= FSL_SAI_CR2_BCD_MSTR; + sai->is_slave_mode = false; break; case SND_SOC_DAIFMT_CBM_CFS: val_cr4 |= FSL_SAI_CR4_FSD_MSTR; -- 2.20.1