Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp256810ybi; Wed, 29 May 2019 20:47:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxILHwXKYe6lmf7bDN7ioZdXtA+WAELYmRVN6GBoFXxALiyorNoKoDG7uy0bVoDJpUUjPK2 X-Received: by 2002:a17:902:758b:: with SMTP id j11mr1716914pll.191.1559188052531; Wed, 29 May 2019 20:47:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559188052; cv=none; d=google.com; s=arc-20160816; b=naJSUImjRT+A8S+G9tVN1aA0KpNQ8pFpMcwD5U+RRsklEpLtvc7Sqkg8tCCtV1PYnB LzWeY6M6RqYDSBddAPDydLxaSj7lE7Ug/WZG5x1TO2Sw8tmn52OWymhSQPxsj322dKr1 vTqQIA1hcG7hnUvlLtsyEgWUEHWXa1L1rMOk9rFapOER/jS3fQWJBNa2Y45ZPuXyECgH wtvS6eMMz/tClbOTnOMmTe0s8zhOsJTTBpiW7Cw7k6c3K/acNZm/gP+vtnzIMSkNRGZi Nx+83ubfR6IVNvh4oeGfaj79zeNL98umImCvfLX50P3pMfOhcJ09vARijGH/LnoMR3rH 1rSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jHCN28kfIQpPO5jrITJqjP8y3zK4ith557LCfR5atsg=; b=yZzVsfwaDVckAz0/9WVNpTpZoSQSuR3Eo/UdwT7JP6OBpIvGicG0vrniG7yB1Htzjq FVFWr54i1cRZiMQXEovt/sHwWLTSCIprCh/UPLlh0CauBwXhtLYUCjb6PjrPjnS5BE0I 8OjBoZ014Sn/jlPLkfrkGRwd3blqZ9+peVBFFEvUSqGPtXt9QPH4gLLL0Kc1JzFTHn// eGSSG+quB1G5rH8z3763oT3S3PYxDognd2jkV3lsAL6+NuKI7dzJR4ZSmDBngpiXVP4B hSaaQH3dOeLLveKKjS/meCEHvim4xp0uy3QIPIQRvOL5NWGW8CEKsAZi+urr4+/X1HC9 fhkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wgGItlKf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si2076019pla.358.2019.05.29.20.47.17; Wed, 29 May 2019 20:47:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wgGItlKf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731703AbfE3DUx (ORCPT + 99 others); Wed, 29 May 2019 23:20:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:41206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730581AbfE3DQF (ORCPT ); Wed, 29 May 2019 23:16:05 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CA952455E; Thu, 30 May 2019 03:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186164; bh=w0FNEcwamqYLDkj3GaVPl4jMvnrBDG1Rp3VxgMOjzwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wgGItlKffiEnG6L/MXKFJ1fxmRg4z9BaYF2Lsjfn9ALsjjAngO7+mXSDJc9v4EuCj Jqxm26eGaoZGL7gD8rQ7DHKChq518PuJMwn8D/DPaD8tofCP5rS+Fs1+erSIgi4QmI cdxC935e1kWurXV0KAhTGgqbWspEPFyp3mo+A7fs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Catalin Marinas , Robin Murphy , Christoph Hellwig , Will Deacon Subject: [PATCH 4.19 015/276] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Date: Wed, 29 May 2019 20:02:53 -0700 Message-Id: <20190530030524.868919123@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig commit a98d9ae937d256ed679a935fc82d9deaa710d98e upstream. DMA allocations that can't sleep may return non-remapped addresses, but we do not properly handle them in the mmap and get_sgtable methods. Resolve non-vmalloc addresses using virt_to_page to handle this corner case. Cc: Acked-by: Catalin Marinas Reviewed-by: Robin Murphy Signed-off-by: Christoph Hellwig Signed-off-by: Will Deacon Signed-off-by: Greg Kroah-Hartman --- arch/arm64/mm/dma-mapping.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -664,6 +664,11 @@ static int __iommu_mmap_attrs(struct dev if (dma_mmap_from_dev_coherent(dev, vma, cpu_addr, size, &ret)) return ret; + if (!is_vmalloc_addr(cpu_addr)) { + unsigned long pfn = page_to_pfn(virt_to_page(cpu_addr)); + return __swiotlb_mmap_pfn(vma, pfn, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped, @@ -687,6 +692,11 @@ static int __iommu_get_sgtable(struct de unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; struct vm_struct *area = find_vm_area(cpu_addr); + if (!is_vmalloc_addr(cpu_addr)) { + struct page *page = virt_to_page(cpu_addr); + return __swiotlb_get_sgtable_page(sgt, page, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped,