Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp259316ybi; Wed, 29 May 2019 20:50:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2iHn/QKQk/ARI0vUvbE+c9gtV7NIITezGG+7Ht4m4pWl4VEI+J3BODjZHxSvUcnnYt25W X-Received: by 2002:a17:902:8a91:: with SMTP id p17mr1802835plo.60.1559188251881; Wed, 29 May 2019 20:50:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559188251; cv=none; d=google.com; s=arc-20160816; b=jv/oFqFStic1Dr66p1nb0PNVIpgtmYxjl4Uk7Aduawnc4Xmh1D0zLEu1aOYRIX8r2D vf03yXfIAC/mA93po73KWui0ATl6z/EZnnONcvKF1kDGbIJwGaAVQ56Gd0qrTr7OZ0eU aOloqoeDTEejg2oXDraCk9iCL7Ku2xPPA+aHooXUh7h4pSsCaSr6qP5jID2Saj8usuNq zFON3YTmwj1deQiKBkWsxv/91eCfmzP2mmDkU/hT89WiC9MN1qsjHVnvu8IhlmmSTyTP 3rZ6OJQZCrdvz88hYUP2cRHunMjW3PIq+1Ovym2PZtpzy1dqdL9orjdaNRMdN0s0wdrY EJ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mVwWQ7ZgnSMa5qN16jUhRteXzGdgUyg9BrxuUMsAW+I=; b=IffqKJ/1g0QOjvdhK5kP+8ux8gRh818qztm07NzRAljDfaf8kIDhGqsVvLvbtGi6/U ASr9PkQ+ocMXf3rCoWi4A9AoiKWy4PrYS5EEYUtE9tIvSzv/UW4NIEgZ0+gZphFwouW8 uiETW6sfMDsvTqFnnY8KUyRfFGrscR0SbKA/HN9AcLHG5oLF+ls9vAOk26DfVeWPr4Ma zB5MjBFTZwU40Ve5tEfbfyQo39etrxuZpbGA1d2ruEqcuGyndPJFL2uE03IOzzVvvbG3 aL4vhwFHy/rvG7zxwCCitf71EUXTWAbHkhU+k/3L7QKc4Hto9pc7iNNh1/FrTfTraIkM 3qOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="VMYV0f/O"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o128si2027421pgo.51.2019.05.29.20.50.35; Wed, 29 May 2019 20:50:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="VMYV0f/O"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732540AbfE3Dsc (ORCPT + 99 others); Wed, 29 May 2019 23:48:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:58046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732157AbfE3DUT (ORCPT ); Wed, 29 May 2019 23:20:19 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7552E2490E; Thu, 30 May 2019 03:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186419; bh=MiooSD0rWkqKK4flaOwrfWB+eO0A5ruYrhlxcARL354=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VMYV0f/OpgilxawMY5EysJ7tdtHC1U/AKl5bG5aQfrCmAzec9mV2XqnpsvEFyWuBk gvlp1p0FidwgbQHOSSEEsv7yAATJK6RLXnUNbm0XuB2lCDwh1xL/jVRmtAD5m/ymbC +bXGAE0+AQ3uRMqffaEm1kivAlUCFUAxpACzFo5U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Alan Stern , Sasha Levin Subject: [PATCH 4.14 172/193] usb: core: Add PM runtime calls to usb_hcd_platform_shutdown Date: Wed, 29 May 2019 20:07:06 -0700 Message-Id: <20190530030511.898815094@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030446.953835040@linuxfoundation.org> References: <20190530030446.953835040@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 8ead7e817224d7832fe51a19783cb8fcadc79467 ] If ohci-platform is runtime suspended, we can currently get an "imprecise external abort" on reboot with ohci-platform loaded when PM runtime is implemented for the SoC. Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown. Signed-off-by: Tony Lindgren Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/core/hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index d0b2e0ed9babb..5fcea1114e2f6 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -3053,6 +3053,9 @@ usb_hcd_platform_shutdown(struct platform_device *dev) { struct usb_hcd *hcd = platform_get_drvdata(dev); + /* No need for pm_runtime_put(), we're shutting down */ + pm_runtime_get_sync(&dev->dev); + if (hcd->driver->shutdown) hcd->driver->shutdown(hcd); } -- 2.20.1