Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp267755ybi; Wed, 29 May 2019 21:01:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxt/ixkLlMiwu7FpW5oD1vVShZvHGQT7ki3wyizx+Rsv1wZ63UU8ZdlfIxv5YVYzPCfZqbT X-Received: by 2002:a17:90a:a790:: with SMTP id f16mr1576852pjq.27.1559188914174; Wed, 29 May 2019 21:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559188914; cv=none; d=google.com; s=arc-20160816; b=Uiwq5GU5KlHZrJNaX/vT3CzOOPUnHyO2dmJ+KlQDHtXrO/tvmOl9Msg7ZPDIg4tK8C Mu1V/87yOtL6SqV5X9YbKBGw/v3qVva2hmVn/yz2bWnoc5E45tHrnzAag9okC3Nsuznj 05w7qhxKCwOhGTJb63ewfflFyUbYsCCd/5NGjcBc93vPWsk9TOXp37KRb/tIwEDjp298 dS4GHDjUvhH2PKHyBb3hkbGv2wnfy/ropZHrkFhwCHg9yFZ6JNRUkoBe/Zsl6s5KU8Pc t6QVjr850jI/pH2L3pt+CGXSYONAHsX91lHrFpqFEkqxDlrTm94RmDIJXp5/44N9bc3y DYDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3pIpM1yuQlZiKEPokjkYtOKfbkZ6/6h3+SqI+lgaHCg=; b=zVXpLpMNTMppp3cuTzFbPaw2XVJDtwcbg8elR96JtXetD7svxxI4kOt9G6iyIb0Sru ezGn0z9KcVp70vZGTWgbrNgFggUqfQeHV3BZUYQqVmCBmybyWljML9tgDfGCxnEfYgfS xXepy6w+KKsQScGSI9gtZpPMUs6h+GUOTd8NPBLT26jsdsOtUNm+2pjQBiYqVm116r7q 8m3mNl2/rRWT0gb1ke9TI8nVv78g1xrWvYAL4GqpS+hXyEbRqPaJxZD8RH443vR4wU85 EI3WDRRb0ygVSImpKG4qDktpUJ8gvT6nCMeapaXct7N1vSvDTgZH6q2Mlkh8ZMyfXOip zLAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dLIfOzVU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y38si2026973pga.231.2019.05.29.21.01.36; Wed, 29 May 2019 21:01:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dLIfOzVU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387965AbfE3D7e (ORCPT + 99 others); Wed, 29 May 2019 23:59:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:51738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730629AbfE3DSd (ORCPT ); Wed, 29 May 2019 23:18:33 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76782247D6; Thu, 30 May 2019 03:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186312; bh=F/I4d2TYGPmga01vGFsbfWUFvfXMpozCYLqNDoeEc1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dLIfOzVUdnjr8Y47x13AQIy4xIuN5WPEKneTRRw2wMqUDCLNmwWjk3vUcGX5if5o4 JB5DaWvdJpyLglOUZt1CmAKHo9wl5UJex3aaQ6sZupulBbmNSpMqTcjyKgZUEOpRgG H+0rJCZF30CsDKu3znwYR+TeH2aYDYKSvx8hjlvw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Catalin Marinas , Robin Murphy , Christoph Hellwig , Will Deacon Subject: [PATCH 4.14 014/193] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Date: Wed, 29 May 2019 20:04:28 -0700 Message-Id: <20190530030449.789621725@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030446.953835040@linuxfoundation.org> References: <20190530030446.953835040@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig commit a98d9ae937d256ed679a935fc82d9deaa710d98e upstream. DMA allocations that can't sleep may return non-remapped addresses, but we do not properly handle them in the mmap and get_sgtable methods. Resolve non-vmalloc addresses using virt_to_page to handle this corner case. Cc: Acked-by: Catalin Marinas Reviewed-by: Robin Murphy Signed-off-by: Christoph Hellwig Signed-off-by: Will Deacon Signed-off-by: Greg Kroah-Hartman --- arch/arm64/mm/dma-mapping.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -710,6 +710,11 @@ static int __iommu_mmap_attrs(struct dev if (dma_mmap_from_dev_coherent(dev, vma, cpu_addr, size, &ret)) return ret; + if (!is_vmalloc_addr(cpu_addr)) { + unsigned long pfn = page_to_pfn(virt_to_page(cpu_addr)); + return __swiotlb_mmap_pfn(vma, pfn, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped, @@ -733,6 +738,11 @@ static int __iommu_get_sgtable(struct de unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; struct vm_struct *area = find_vm_area(cpu_addr); + if (!is_vmalloc_addr(cpu_addr)) { + struct page *page = virt_to_page(cpu_addr); + return __swiotlb_get_sgtable_page(sgt, page, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped,