Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp268245ybi; Wed, 29 May 2019 21:02:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBY6c5xdMTtpKCPezcGYjNX0MCpnNFDTZ3hWb56UjBZWtuwv6+Yp/cEONrYsGa7xSk9Il1 X-Received: by 2002:a62:e90a:: with SMTP id j10mr1614591pfh.147.1559188941374; Wed, 29 May 2019 21:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559188941; cv=none; d=google.com; s=arc-20160816; b=D4hgWM1yAvRevDyHw9iacjj9cXOKj5q6jkAGs0gCWdm8Wwl4eNfI2Js5UocACKse/f EICAL9uZ3BVkGFM404CEu8Aaec7eg7DiyPKOB62p47gi9l4uBSjibHHXjiIhosJDYzYp NUghZ6A5eoemOcFVeg+FzkkU144PlaXbmbBvdh2HkuHJdBTTtM4B4aZvkpvpyxbJplbC 2cQxQahgnkliPunG7glAtxrCBxgcvq+dPlE92lWokJml8kPcQsT38SMscIMYzAtMjaC4 woraxHv5ihPT3PEk4uN4IGKvWm/fnw+Fnj5eqSQa2VndS4uEevi0t3OHVSu6StVgdxXT xgKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=L4UGQEKXwOJMQsZrmtSjAZbt8HoqWO9XeI7lJmf9uXM=; b=kfTrKKswjx3rgOTFe2sJ60rOKZKeWleNfM0wRONHnPH0wNrfMlTPBDHAziwXH4ITyZ Ms+E/JZw8JzexLFmWmDDeRU6HLE40mIDNEjldc2Nm6hxXdoPMnHjhJ98HgLVWVdIdI8f uMc9WDYQEoTJKIRPdW3FkWFYzfaX+4Luv6QVeGTEh4fY7nCeGUnTYxS2H4d1NZqu37aq 1pnqyGPGmUMwi8irBzbhi1MppJH840yY7rAmeB+NJE53fY8q8RoL7s3377AK4D3cXKo0 O51UdCgl6+p8Rt2g1SxyEoIkHVnyeDYVh+QD/x7uIiAHSqaBa8cSQl0PwJDpmHgFyU5o R2ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B237X1lj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g190si1961042pgc.1.2019.05.29.21.02.04; Wed, 29 May 2019 21:02:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B237X1lj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731102AbfE3EA4 (ORCPT + 99 others); Thu, 30 May 2019 00:00:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:50450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729107AbfE3DSO (ORCPT ); Wed, 29 May 2019 23:18:14 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1423245AF; Thu, 30 May 2019 03:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186294; bh=20NGHh9hI3pUhV5NSLVTioijjfVOpQ0vS7J9QaqBhV4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B237X1ljmYZ6TQmfDGchEi9vk9aIQutmdC3IHa8veRiVYgfYVKmxBtyymSdNx5xyk K/6h5MPLJ4J4KIN81OiOp8iiy7E/oNPRfMLO5U9YpdYLplVrrQeVzRP5PFy7G1f3G2 tDjdgQD+WLuXVjuqzHCMovy2nPnUGisDNTj/Q5jA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Murton Liu , Aric Cyr , Bhawanpreet Lakha , Sivapiriyan Kumarasamy , Alex Deucher , Sasha Levin Subject: [PATCH 4.19 253/276] drm/amd/display: Fix Divide by 0 in memory calculations Date: Wed, 29 May 2019 20:06:51 -0700 Message-Id: <20190530030540.954741678@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 59979bf8be1784ebfc44215031c6c88ca22ae65d ] Check if we get any values equal to 0, and set to 1 if so. Signed-off-by: Murton Liu Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha Acked-by: Sivapiriyan Kumarasamy Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c index 4a863a5dab417..321af9af95e86 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c @@ -406,15 +406,25 @@ void dpp1_dscl_calc_lb_num_partitions( int *num_part_y, int *num_part_c) { + int lb_memory_size, lb_memory_size_c, lb_memory_size_a, num_partitions_a, + lb_bpc, memory_line_size_y, memory_line_size_c, memory_line_size_a; + int line_size = scl_data->viewport.width < scl_data->recout.width ? scl_data->viewport.width : scl_data->recout.width; int line_size_c = scl_data->viewport_c.width < scl_data->recout.width ? scl_data->viewport_c.width : scl_data->recout.width; - int lb_bpc = dpp1_dscl_get_lb_depth_bpc(scl_data->lb_params.depth); - int memory_line_size_y = (line_size * lb_bpc + 71) / 72; /* +71 to ceil */ - int memory_line_size_c = (line_size_c * lb_bpc + 71) / 72; /* +71 to ceil */ - int memory_line_size_a = (line_size + 5) / 6; /* +5 to ceil */ - int lb_memory_size, lb_memory_size_c, lb_memory_size_a, num_partitions_a; + + if (line_size == 0) + line_size = 1; + + if (line_size_c == 0) + line_size_c = 1; + + + lb_bpc = dpp1_dscl_get_lb_depth_bpc(scl_data->lb_params.depth); + memory_line_size_y = (line_size * lb_bpc + 71) / 72; /* +71 to ceil */ + memory_line_size_c = (line_size_c * lb_bpc + 71) / 72; /* +71 to ceil */ + memory_line_size_a = (line_size + 5) / 6; /* +5 to ceil */ if (lb_config == LB_MEMORY_CONFIG_1) { lb_memory_size = 816; -- 2.20.1