Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp269202ybi; Wed, 29 May 2019 21:03:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVs89H4X2h+7eBWiWpyOZGK88bCrRK870OMRuuWrinUDcC+lvqmrfa7BlPR5ATDTsY+vQx X-Received: by 2002:a17:902:9a83:: with SMTP id w3mr1787862plp.184.1559188997892; Wed, 29 May 2019 21:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559188997; cv=none; d=google.com; s=arc-20160816; b=VRPrXPFz3Q8qyCFwaPy/nAaL3BVdLqgi8QEJS/i/XNrldxLe0zPUSKZuFB+SrFDBca wA7IDPyBBqbewRnpV57ZT8VvO4J71qIuboOq1UcruCRshzUdXJl16NxwsWHpgbe4IlD8 xOT7m7Ngwwej5VQvsQ6oOPHi4p8bqUcHaV3gs74nUWpfIcnZtGeb35iVG7Rl4quVJ4dj +3SbJvSjpt0zw4bzZqVH55YMkN19/w5CXk1IG4HO0AK01RlX9cc0fW8Bgv7iMPv5jyDS OnbPX+zyxPwBqD9QV+DsN6JATHpRb8A2vBzPSR8b365VIUoQzcsSSy3IvjI+5DvVUIRO B3rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aMjxoU/FZD5qm/Z095sx5Pe8itM+/JTtouCP0WHPbi8=; b=QASxsCKkOVIQ62AOiErTYaX7Y8TAkxEbtHAXJHb4wffLCAlQJd+07/+d/e9DtOWZDh dqeVjJ1SWf8Qm/rO/uakkw9kmSOTjMAd3hPR0Uy75DQ0zwD9C/Eg9e5J3PbbpMX4fN1g x2yfmOPZ2h4IGPRgspdNTBI56CvFi5Aeep7P0Q/OdwqrvRsJlyk8nQ9+XghBtCN5xpSI Y0hWuOLjlK/YZG9yv6OevK8NqUDaUviVQQ1Oo7dbNJVx6uxRT7A5vzNfmxnjVMjy+9FO 4CbbmOKQj7UXhHg6eUgUyo8X2YiRL/txmXfTd92FZUvZoZHnjQIjOuprcXRy+my1O88u 9XPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q5mFBGMz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si2107685pla.121.2019.05.29.21.03.01; Wed, 29 May 2019 21:03:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q5mFBGMz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732172AbfE3EBP (ORCPT + 99 others); Thu, 30 May 2019 00:01:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:50226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731455AbfE3DSL (ORCPT ); Wed, 29 May 2019 23:18:11 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B66F824764; Thu, 30 May 2019 03:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186290; bh=B1REWhhUT/QzQkBeseofxK6UAlJ9OwSyGnb7velQKW4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q5mFBGMzsD0+zA06tiLivczBXL7At07Y1/EfAFnwrWBE86Y5mgNNrMY/zoqPlDb2m B5Q5I90oyBg8UMFMIvICbzIe9adZSWrM9J/rn41R/iQP0QA82RYygJfSoJPoL5fN4E jYr41BzFPYsFzcebb9CvJRai33yFpBTR6yKLM7WM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai-Heng Feng , Aaron Brown , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.19 248/276] igb: Exclude device from suspend direct complete optimization Date: Wed, 29 May 2019 20:06:46 -0700 Message-Id: <20190530030540.657718120@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5b6e13216be29ced7350d9c354a1af8fe0ad9a3e ] igb sets different WoL settings in system suspend callback and runtime suspend callback. The suspend direct complete optimization leaves igb in runtime suspended state with wrong WoL setting during system suspend. To fix this, we need to disable suspend direct complete optimization to let igb always use suspend callback to set correct WoL during system suspend. Signed-off-by: Kai-Heng Feng Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index aa39a068858e9..5aa083d9a6c9a 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3468,6 +3468,9 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } } + + dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_NEVER_SKIP); + pm_runtime_put_noidle(&pdev->dev); return 0; -- 2.20.1