Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp269545ybi; Wed, 29 May 2019 21:03:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKJ/KkVvhysVAozyN9G3AhZtdeWQLErysXsY4oTRZ1x1w3P4351BdOKSJ6AvulLTXBKFoD X-Received: by 2002:a17:902:b590:: with SMTP id a16mr1841132pls.168.1559189019642; Wed, 29 May 2019 21:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559189019; cv=none; d=google.com; s=arc-20160816; b=HGdGMNO+0oNAL5txmoVh6jY+HHJAXaJw5ytGoFdwPJaOTfttHkaJecIowd/RRYVwjZ jymdK1YnbrXTZCsgjHti0kDuUQnTl5w5yySs72IzLTSBzW7HcICPvkVX5ZVi/ib9w0ji bAsRF4DRNA4eAHp+ZS16oJMkoe1HRpO7KVNkxS5SijnYPA5uEdkU6LW+tmQM/WIvS4sm c4TbT8Hk8Wp/yUMBuLZEm5sZK3yfFL+4AImY96Lj/h8ZzziBdkbTs2GbIzgfogKfYfxr HUCiWo6r9goKat9XrlvjHoKy5Sv1wy4MAqzhaL7aovxwgltJ/8Twc9d+KN26g4VYnjYh BJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D2/gmkq/ePki4K52sHEmmAKzRXvh3LOxTXnN3WkGBGQ=; b=qreJqem0/qPhl8wePjMQgH7j1huzDHli25c3DNLBGsEszKVQs2XOnXvycuCd5lRHI1 TLMi+bDu6cA+WEdtSLigqT1A5dVQNzvVAdP0e87epoZrLG/QaiOwgvqxVikHbNxDouGW he5bY0x9u50M79lzbXFz77oOZ1OOdivcwbMVVu2EFeZ3NIJ4GtvSvIrE6PCjSqUm4JiT kq8zXvUs7lKVBYmgobsBhAWqGy/5VWMkzYO86UXo2mJ9tdv/NNSa5OEDBj2aX+AbFMLF 4SUF36dTFNy0z/Eyzvu2rEk230ugZi398c29KW9LIhwz1bymOTBvIKSLwMwUiGCmPmOc gLwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ztT2CE1l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m62si1715100pjb.1.2019.05.29.21.03.23; Wed, 29 May 2019 21:03:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ztT2CE1l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387440AbfE3ECG (ORCPT + 99 others); Thu, 30 May 2019 00:02:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:49736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731398AbfE3DSD (ORCPT ); Wed, 29 May 2019 23:18:03 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD15E2475D; Thu, 30 May 2019 03:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186282; bh=yIgeGhkdPB5M6GuadWfHBcGZhxxwD9M3hoixq8qO45I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ztT2CE1lt5mrvtfjGS8oMZcj1kCK7JMAXajH0qFegEg3mbyrYqxmgDCAxBAxL6T4Z w7k+kvzRYNZjcx4t+ejvBmLQVHaY4mGdbzJIY6GgV89y5YZ7yzEGk2fhjBiqk0OoN1 FmzFYsWT/yTPk668C7BXzwbzSjxS2rMrMEUpE+hM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Alan Stern , Sasha Levin Subject: [PATCH 4.19 235/276] usb: core: Add PM runtime calls to usb_hcd_platform_shutdown Date: Wed, 29 May 2019 20:06:33 -0700 Message-Id: <20190530030539.824340594@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 8ead7e817224d7832fe51a19783cb8fcadc79467 ] If ohci-platform is runtime suspended, we can currently get an "imprecise external abort" on reboot with ohci-platform loaded when PM runtime is implemented for the SoC. Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown. Signed-off-by: Tony Lindgren Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/core/hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 1c21955fe7c00..b82a7d787add8 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -3017,6 +3017,9 @@ usb_hcd_platform_shutdown(struct platform_device *dev) { struct usb_hcd *hcd = platform_get_drvdata(dev); + /* No need for pm_runtime_put(), we're shutting down */ + pm_runtime_get_sync(&dev->dev); + if (hcd->driver->shutdown) hcd->driver->shutdown(hcd); } -- 2.20.1