Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp276178ybi; Wed, 29 May 2019 21:11:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMPNpSx1kzAgcwjxcYEOW6bVH5TIOJ1rQsAjUfg+P+gqukyb6RP3VmsZpBLS2/5FyB7rnO X-Received: by 2002:a63:1c4:: with SMTP id 187mr1876515pgb.317.1559189508531; Wed, 29 May 2019 21:11:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559189508; cv=none; d=google.com; s=arc-20160816; b=KXASVdN8MU99Cw4AKtqWOnjE3iFXLUUOjh3iHAENXsvx68MdqQdGnUTFQroHD9Mw91 i64rAO8I7QD08zTlkRJhzjiSz6ehIFANJ0QEwNK3prxCJTnV8Mcrhhaggu5wcbM1N51j hRNOw3TqhmWRBg1iGrj+Yg5I4Z63psYOMe8gGZmnANOeAVGpmuSlKGIYrPzqoSFc9lLu p5TS+2C94Zz2arICudr5evjhcPrZcaqQP3N4KC4YeV6ZynGVTPW+896OyBAG6F9QuXXf h91VlV4APhGHkwVmynzylbcbPSNSUdTV0cyEh3VnglSu9p5S1s8HcuOvoE+OisFs+4ZO VIsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4U1tSl2/pwwwj2i/AOpyNMW1qgVAy9AcmRZ74EQKpnM=; b=uWYv01jW6tsQQV72FX0tzgS16VScO6octvS7OMwFUaN697JiqJ92aiKqimuHoSGziX EUmd04JsyxuvdJRkaDGbGznS5ypQKwy77kMr9fftNicRSJS3LlJqKiahh+vBD8yL7pNb oCR5hbjckbFpeTaPBiNymbmGX4aH17RNKAD/O5kzuOzVT/aXcFF4zfTDkvRLX3d7SrTY qIk3qgNkv0CZNxCulwSNPZR5l1OP6IGXyohxTCjRcEiSfSEFWivfnHw2kLDzzsBFOI1j s8+HQgHAGqFTVuEOS3mbnNc8uvidGNi5krI4yZTcAb1I31i4Tw7ug8Hky42NL/tkc18w Y5cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=O84W8lld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si2372935pfw.143.2019.05.29.21.11.32; Wed, 29 May 2019 21:11:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=O84W8lld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727310AbfE3EK3 (ORCPT + 99 others); Thu, 30 May 2019 00:10:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:44490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730041AbfE3DRA (ORCPT ); Wed, 29 May 2019 23:17:00 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F020624646; Thu, 30 May 2019 03:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186220; bh=6h26VJK8y3zY9Qgl+h44YIBxuwaD1N9LgE/Wq8QcILc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O84W8lldKYZ3VklVv6HCnTV/vuyL2H2ycTvs2UJO40TCAhrcJmC+tH5UKYRPKU7TB x+eW7w0bCNqQsedNjgErMqR9QOCvpxj/lwVNHMzGRxIAkUWOgf1hw0lyWF8qN94ekW 6dx7ZdmaV46ZknwQnWndsOvrj+OAF1696H4afOTE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kees Cook , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Sasha Levin , Sami Tolvanen Subject: [PATCH 4.19 110/276] x86/build: Move _etext to actual end of .text Date: Wed, 29 May 2019 20:04:28 -0700 Message-Id: <20190530030532.875031639@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 392bef709659abea614abfe53cf228e7a59876a4 ] When building x86 with Clang LTO and CFI, CFI jump regions are automatically added to the end of the .text section late in linking. As a result, the _etext position was being labelled before the appended jump regions, causing confusion about where the boundaries of the executable region actually are in the running kernel, and broke at least the fault injection code. This moves the _etext mark to outside (and immediately after) the .text area, as it already the case on other architectures (e.g. arm64, arm). Reported-and-tested-by: Sami Tolvanen Signed-off-by: Kees Cook Cc: Borislav Petkov Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20190423183827.GA4012@beast Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- arch/x86/kernel/vmlinux.lds.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 85e6d5620188e..2fb152d813c17 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++ b/arch/x86/kernel/vmlinux.lds.S @@ -151,11 +151,11 @@ SECTIONS *(.text.__x86.indirect_thunk) __indirect_thunk_end = .; #endif - - /* End of text section */ - _etext = .; } :text = 0x9090 + /* End of text section */ + _etext = .; + NOTES :text :note EXCEPTION_TABLE(16) :text = 0x9090 -- 2.20.1