Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp310346ybi; Wed, 29 May 2019 22:01:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDqxkkP28aA4Kvl9o1v4vonFL7MB/YvK+oh0zcPMy7PKGzsAsUJ+01XqBmJdvE67ETuSDW X-Received: by 2002:a17:902:b68c:: with SMTP id c12mr1994436pls.83.1559192461159; Wed, 29 May 2019 22:01:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559192461; cv=none; d=google.com; s=arc-20160816; b=FjcIQnxfRXUeOpCK00voul0hsJsZorDVOjOiowQfZEsYhtN0ss8sAwvVWlHH6tnEUR gUH3MTGc7oQen0gg7KCcuI0VvBxq656asl7HzL9IkqsgZF2I3+XfGijCN1B1zP4Lvpi4 A9bt2WlsZpOnlxDlou/x0NwRHpVVlXdapbv2dRNxJu0YktRg14LJlFKQhTKRj2VI/Fwa wPn/s9tl3awTBfReh4InR/G7N5ryGI1BUmdu1DNdfVQYfDI9FHNbbJnSB7GKv8fSrsvD TKM9hPwqPP/vSAkUibh9zJ19S7+6zC/NXthFu+3NlxNO41/DVgAv2/5z4SIbgj7mU4T9 772w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ClwytLeUF4WVfMeLlTzQ2mXGyTdVgc/4ZTlonxjTGjQ=; b=j76ZAyFsrCXqGHDFCLJxk8huX5DyTXCXfDr1BVqf07Qsm7Zf0iapmf29OesAyuLBAl gpdqVUrEBER1nmYgCy7IYbfokJ8JcJLOJkzGK8TUVO8KdLceUXdDI15lFhoBibTj+tYr y9RQPDvkdpLfOD+l6Qh2a1i/nem8QaDhqJl1RMh7l+q7ot22WQlEXpU3NRR2fAL6YkQW 3AUitmCmBLSHDp6qYbxb+PtsahJi/rkwH8xDinAnit3yHxkOxpG64C43gTLRiVg5/PBo 1KccdBbFP8/6SujaE+FUeIuz611O9hMZgb0R6ULVFrREcMcBbOPKVOVrTc45AOU+quUo qAdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M0TuE1mV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g67si2030084pgc.344.2019.05.29.22.00.44; Wed, 29 May 2019 22:01:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=M0TuE1mV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387503AbfE3E5F (ORCPT + 99 others); Thu, 30 May 2019 00:57:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:45216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727875AbfE3DJ7 (ORCPT ); Wed, 29 May 2019 23:09:59 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD7EB24493; Thu, 30 May 2019 03:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559185798; bh=UT5ptIzvBWmArzRHvLDDWZswCaWyxEW9/R4B4KcsSDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M0TuE1mVhYHNTGga2n7vWuTrsewZs//CPnM1FP8MTRGPo78BYUCU8ZVsKx74x2TEs q6PAIHgr18Vw7ApoEF2xiwJOf9c+WuEF7egvh8mOWlNfy+p2viasHtloIxcYG9RUGK RXxwJFdnyxfu71h6yEDuHFVdkq3IbIWRHZZreryA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bo YU , Michael Ellerman , Sasha Levin Subject: [PATCH 5.1 075/405] powerpc/boot: Fix missing check of lseek() return value Date: Wed, 29 May 2019 20:01:13 -0700 Message-Id: <20190530030544.744962607@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030540.291644921@linuxfoundation.org> References: <20190530030540.291644921@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5d085ec04a000fefb5182d3b03ee46ca96d8389b ] This is detected by Coverity scan: CID: 1440481 Signed-off-by: Bo YU Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/boot/addnote.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c index 9d9f6f334d3cc..3da3e2b1b51bc 100644 --- a/arch/powerpc/boot/addnote.c +++ b/arch/powerpc/boot/addnote.c @@ -223,7 +223,11 @@ main(int ac, char **av) PUT_16(E_PHNUM, np + 2); /* write back */ - lseek(fd, (long) 0, SEEK_SET); + i = lseek(fd, (long) 0, SEEK_SET); + if (i < 0) { + perror("lseek"); + exit(1); + } i = write(fd, buf, n); if (i < 0) { perror("write"); -- 2.20.1