Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp313311ybi; Wed, 29 May 2019 22:04:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhkPaDoFs0QtkUXuLbMZYVkWUuguxjkpzlUI1CX3KiLzrUSCFS3st8Xfj9WIloMCmb7aRG X-Received: by 2002:a63:480f:: with SMTP id v15mr1977693pga.373.1559192651496; Wed, 29 May 2019 22:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559192651; cv=none; d=google.com; s=arc-20160816; b=T7STBVS/lKuQUEgCAi8w5FfHnZEOOnq8xO68gvd9Rs0WHfKllwArSdopNF3/txOy7S UaqJPZTmwDV5lcQ5EHNFgFKFWYYOp46cEXfNwkULcCUPaJdfTuvqQRD2hkeVZkkKyffh HO4X03P/6CAf0d2Uusgf65au9OAOIACsx4IS0UyKkPOlOko24DuYNu3DYYQVAZC8xVYk A6groByC94MUFpC7PXOqFsKkJp5LwmRUB7RKM8ILJg7TZxOP1whGqmeqfPmjdEEQBJAF 5+4OBqeIeht9tDuDCzMaIDoGGPZf/2Pr02KLMTtrp7YlJSeTBBWYveqaE1nNPBv5A8MA mhyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y+b4T6gH3fumpNM+mGGeVs2xoJsirxGa3FE2HpJ5Lns=; b=Tu8iYaFEwMk1qMt7kIyIMfpIEOphKuaPeMAZ90E4aZoigT07hSye0bHAsFo5wJJCqm 8U3bIuq+BUZNBkXeBWphs/Norl7AXRbreVtCuWJQ8yrirFM46RLnvOCie7o2/vDDr0FG foUIq65mhDON+ii+TfP9JZ7jyuTFf2gcGIsVAHEY5VhzFdtg15fv/OWJmgUjtMww/jCg BNE/dSQfFz05MQD2B7WO1p0BPf/aaBYJmhZTH1ENL0H1JWKw3BsfcP6YM/rYhNE7f1U4 hHs4gcewIsvIDclD1Rk8ZXTyE5W2n9+GJ8b6UWBqsgFSFEfpOoRSFrTN6dj9JeiTCA8m r/OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BfhsxlQm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9si2002264plr.71.2019.05.29.22.03.54; Wed, 29 May 2019 22:04:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BfhsxlQm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389376AbfE3FAh (ORCPT + 99 others); Thu, 30 May 2019 01:00:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:44064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727593AbfE3DJa (ORCPT ); Wed, 29 May 2019 23:09:30 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3399024485; Thu, 30 May 2019 03:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559185770; bh=D22WBElfsfKcrJroUrR87y58gP39ciTL7nqz0YFONb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BfhsxlQm6qwOvsCoHHyNQzD71SocWn9Cmb40ovdPWDWfBEGCjChj6WckNpMLSeZlM xVJx2Irw0pAGtPi4K2PZMYiiUxhb8lwuDfBR5TLcxWLmbgJ3ax1hBlnCaXZINmGCov 0p1f1E6IjIswsx+Cbd3SbpRqIfA+ePncWbqXKYjU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Catalin Marinas , Robin Murphy , Christoph Hellwig , Will Deacon Subject: [PATCH 5.1 021/405] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Date: Wed, 29 May 2019 20:00:19 -0700 Message-Id: <20190530030541.674075690@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030540.291644921@linuxfoundation.org> References: <20190530030540.291644921@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig commit a98d9ae937d256ed679a935fc82d9deaa710d98e upstream. DMA allocations that can't sleep may return non-remapped addresses, but we do not properly handle them in the mmap and get_sgtable methods. Resolve non-vmalloc addresses using virt_to_page to handle this corner case. Cc: Acked-by: Catalin Marinas Reviewed-by: Robin Murphy Signed-off-by: Christoph Hellwig Signed-off-by: Will Deacon Signed-off-by: Greg Kroah-Hartman --- arch/arm64/mm/dma-mapping.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -249,6 +249,11 @@ static int __iommu_mmap_attrs(struct dev if (dma_mmap_from_dev_coherent(dev, vma, cpu_addr, size, &ret)) return ret; + if (!is_vmalloc_addr(cpu_addr)) { + unsigned long pfn = page_to_pfn(virt_to_page(cpu_addr)); + return __swiotlb_mmap_pfn(vma, pfn, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped, @@ -272,6 +277,11 @@ static int __iommu_get_sgtable(struct de unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; struct vm_struct *area = find_vm_area(cpu_addr); + if (!is_vmalloc_addr(cpu_addr)) { + struct page *page = virt_to_page(cpu_addr); + return __swiotlb_get_sgtable_page(sgt, page, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped,