Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp384042ybi; Wed, 29 May 2019 23:36:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxoJH6L4Flepd7oJLNF0lTC8W9MfOGBtbhiUPwC5ZFvI3sylcVNScRRuLrsLloqwHAklzi5 X-Received: by 2002:a17:90a:a601:: with SMTP id c1mr2231192pjq.24.1559198214556; Wed, 29 May 2019 23:36:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559198214; cv=none; d=google.com; s=arc-20160816; b=ud2iYe15EMZLUwNJuhZCYRO0bMGTb9zR/bfKfufIhvVnITBXSIqcQiDhEd+a4ynEBS wq5V+oxGqOZxFYpI/8/Wgm2zOWC98XuBn/7l+EfRkCav/xD4POOuH9zp6B615/gkh43j /mhsm9Cf4LAoLnp6bd1phi+HEhwvBLPU/XHKq04j/xedNgEsR3wACk55PWi10jbwhxAN 9eNJQ0ZsOEOgcBhfYIJshhIB66Kw1RkMYkddSlwnGt/qzxBbzlAAn6SBeHd8wHZLDkS6 q8tTKkUjOPZa2cZXDyYrWVyjGUeT8ch88I+x/bKHnO1TyKH8Ut6UHi2lOtMwwoNrSlHg fmBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jr8TFbprzSDAQ8IU8dPBj96p3eA/WBFaKx/uITpNZxo=; b=qX9CC1/8DYu3Gy+wajDO5kmXG85hHlI9rr+JeA4a8XVWOYfOrS9iYUpLDF3EZ3rGlZ Bc4ndR4zuFW0XCL45zawA+E1wAQreLMbcOhdtMBn9RBHuWXurEjVp1wQ6J3Hz0xZ0MQ6 DMwlGcBAnwJ7xVU6IAqkqTPeytdwxmSfznwCni7bAIeDYaePF5oLrtzJ4gisYg+j3Xp6 24E9h/k9BK9Bb0v1ErQ/8Gf/st5CazXxWozKkTqD2s6ff6kUcGO7kwiLv+0hEkOx7wqB HGfvMe/ae+OtwfxM35KUfdIrMYNOgQMEzBXaA+Z8PtzOUnFAPIG8U/NV3Juzcjp4TOPB T0Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qw1P2yCe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si2245452pgp.118.2019.05.29.23.36.38; Wed, 29 May 2019 23:36:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qw1P2yCe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfE3GfA (ORCPT + 99 others); Thu, 30 May 2019 02:35:00 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41688 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfE3Ge7 (ORCPT ); Thu, 30 May 2019 02:34:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jr8TFbprzSDAQ8IU8dPBj96p3eA/WBFaKx/uITpNZxo=; b=qw1P2yCe/tNQ53IWK8sRhTlQ/ 7BOzfMuds62GDyiMXXH0kaXp1Y+C9rv3rPLSzwvtXfy2QGuFj7Z4GM+RO8YF28VJED1HBAVuJiacv HfYJ8LtXhewzVwZPvZj+5oYXx2zT6rEK1SyEt/ODgaLXdjqFaYQUKil4+7nXra90GSGQk7EXlZj8Y zR8FSrFgCmzAQsmE0qwBRRVez9amvdlg3cLbTtuDXOhSU8dOxHmsBsyayqcOKZhpq7X5TjV0Vtph+ SNe5iYHi6xjjdAMoXuQN3GXfEYLx/kF6PhaP+VsY3yVJyVgoDw6XzDkR0ixeywqN5YUy/hPRiubF1 hBGqc8phQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEeR-0000fN-4p; Thu, 30 May 2019 06:34:59 +0000 Date: Wed, 29 May 2019 23:34:59 -0700 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Mark Rutland , James Morse , Andrey Konovalov Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() Message-ID: <20190530063459.GA2181@infradead.org> References: <1559133285-27986-1-git-send-email-anshuman.khandual@arm.com> <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: > __do_page_fault() is over complicated with multiple goto statements. This > cleans up code flow and while there drops the vm_fault_t argument. There is no argument dropped anywhere, just a local variable.