Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Bitan Biswas <bbiswas@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Shardar Mohammed <smohammed@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Mantravadi Karthik <mkarthik@nvidia.com>
References: <1559196850-7007-1-git-send-email-bbiswas@nvidia.com>
 <e9e3d8b0-a76a-81a9-1110-2d07ba1c787f@gmail.com>
Message-ID: <911e52ed-8f3c-583a-7610-e38723219eca@gmail.com>
Date:   Thu, 30 May 2019 14:43:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <e9e3d8b0-a76a-81a9-1110-2d07ba1c787f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

30.05.2019 14:36, Dmitry Osipenko пишет:
> 30.05.2019 9:14, Bitan Biswas пишет:
>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>> except for BUG/BUG_ON checks
> 
> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
> hence there is absolutely no good reason in making system unusable on a
> software bug. BUG_ON may be more useful for development, but not for a
> casual daily usage.
> 
>> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
>> ---
> 
>> @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>>  	u32 *buffer = NULL;
>>  	int err = 0;
>>  	bool dma;
>> -	u16 xfer_time = 100;
>> +	u16 xfer_tm = 100;
> 
> What's wrong with the "time"? I'm finding the "xfer_tm" as a very
> unintuitive naming.
> 

Also, please don't version patch as v2 if v1 was never sent out.