Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp951127ybi; Thu, 30 May 2019 09:11:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWaTNNf6iKgWX/QPBfNRSJyVWVkzVXxUYwqvpgtyzwOInCvUcoo8gOxfFN2iMqfzP5irM+ X-Received: by 2002:a65:48c3:: with SMTP id o3mr4375379pgs.351.1559232695937; Thu, 30 May 2019 09:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559232695; cv=none; d=google.com; s=arc-20160816; b=JCa6yZadztVZH4xHbtZf2qnh8sxKhP/nnGSOdeZdMMmvNLiT4QG4SZJ3ojRkc1xGpo 4frlbtEgPxEB1DAT3sCkTkYb+OhqrVOp/sgzQnqDdg8gjaLHqcHgoc9phnFFelFRPxO+ 8fQODkihQq5ceh4pG/x8OOVtk90/tCKjDdqHpIHaX0gK2nVHvnds+ljo/qMMtCUe9c7G AoWVnyzwNrsxDzcHGwdYTkQRJ2yd49J+hWQLSxHPJRYQ39oOA7VvmfXko2V+2IWyg1EL zaNCb+Th0bVLZP4otsZiRKlT4dxYG0uAqUH1K3oq5daA6PzxbVwF5q4rlI/qAiXRfmI1 DkFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jmyIx4d89lHokK2LwB3NSS9xzxTqOVHyb0WszveHRsM=; b=CgMJPleKtnau5alY098YfIf/srQkc2JxwjYovCpj+GAKftrzqnOy8XZsXzHUcSTnGd HAiiiCcVFjR52vGb4Kj/hYMNHWbuIa82CGpvGWlpVNiUBqx8S0HSD465VpcKlV/tCvB9 XcadAlTyKpP/NtLmQhtgkTQJuU0gWkltyZyrDAwVNbuTEKawwcoqqfWxOWdcJg/nDqPf 8iFeONiwaSwQbPCTF/A3Q03XlQszGeBwSqaCLoAi7Fa6nQP0BB+miFoTuk78zr036H6/ s/q8nXKAMe0zyiKudgSSgtPYHPCoRVG3Js3zNCPnuWMVdjnmAmUwxTt2VRjKFtN0nx4B sjPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g17si3325491pgd.389.2019.05.30.09.11.17; Thu, 30 May 2019 09:11:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbfE3QId (ORCPT + 99 others); Thu, 30 May 2019 12:08:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfE3QId (ORCPT ); Thu, 30 May 2019 12:08:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5044307CB5F; Thu, 30 May 2019 16:08:32 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.159]) by smtp.corp.redhat.com (Postfix) with SMTP id 71FC9104B4EA; Thu, 30 May 2019 16:08:25 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 30 May 2019 18:08:32 +0200 (CEST) Date: Thu, 30 May 2019 18:08:24 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: Deepa Dinamani , Al Viro , Linus Torvalds , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, dbueso@suse.de, axboe@kernel.dk, dave@stgolabs.net, e@80x24.org, jbaron@akamai.com, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, omar.kilani@gmail.com, tglx@linutronix.de, stable@vger.kernel.org Subject: Re: pselect/etc semantics Message-ID: <20190530160823.GI22536@redhat.com> References: <20190522032144.10995-1-deepa.kernel@gmail.com> <20190529161157.GA27659@redhat.com> <87woi8rt96.fsf@xmission.com> <871s0grlzo.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871s0grlzo.fsf@xmission.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 30 May 2019 16:08:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30, Eric W. Biederman wrote: > > ebiederm@xmission.com (Eric W. Biederman) writes: > > > Which means I believe we have a semantically valid change in behavior > > that is causing a regression. > > I haven't made a survey of all of the functions yet but > fucntions return -ENORESTARTNOHAND will never return -EINTR and are > immune from this problem. Hmm. handle_signal: case -ERESTARTNOHAND: regs->ax = -EINTR; break; but I am not sure I understand which problem do you mean.. Oleg.