Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 May 2019 11:46:02 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Luwei Kang <luwei.kang@intel.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org
Subject: Re: [PATCH] KVM: LAPIC: Do not mask the local interrupts when LAPIC
 is sw disabled
Message-ID: <20190530184602.GD23930@linux.intel.com>
References: <1558435455-233679-1-git-send-email-luwei.kang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1558435455-233679-1-git-send-email-luwei.kang@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 21, 2019 at 06:44:15PM +0800, Luwei Kang wrote:
> The current code will mask all the local interrupts in the local
> vector table when the LAPIC is disabled by SVR (Spurious-Interrupt
> Vector Register) "APIC Software Enable/Disable" flag (bit8).
> This may block local interrupt be delivered to target vCPU
> even if LAPIC is enabled by set SVR (bit8 == 1) after.

The current code aligns with the SDM, which states:

  Local APIC State After It Has Been Software Disabled

  When the APIC software enable/disable flag in the spurious interrupt
  vector register has been explicitly cleared (as opposed to being cleared
  during a power up or reset), the local APIC is temporarily disabled.
  The operation and response of a local APIC while in this software-
  disabled state is as follows:

    - The mask bits for all the LVT entries are set. Attempts to reset
      these bits will be ignored.