Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1155687ybi; Thu, 30 May 2019 12:30:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKPrXGwZ8p/PyiD75IATjhGKe/S5xklRMholcVKCI3aA0iRhpBHcAQEmgYGJWidDdM1mB1 X-Received: by 2002:a65:5308:: with SMTP id m8mr5132965pgq.54.1559244644960; Thu, 30 May 2019 12:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559244644; cv=none; d=google.com; s=arc-20160816; b=UNuEWLFX4p0IZfVy0uvjMkt3wZDwYrwOZDt/tcwS4LJwM+SWf4ekQHHvxgV82WB9k7 xBTnMop7Of+8UKlpwdpKUUALncW8hCgTKK+ovJjUtXR/9j7OGq/tkuJh0Fz6fIfpqDka WtR+Fqma4Sad+vpr8giN2JcUB3/bJEq066Qf47LigNU4JS+KqmVIThqzTBfADgtdMEO9 2YIljjBxClOIWi/ZTiiVl3uAx7zbzB1VHS6F22QfAx9vapAQmP/dhvGgQWr1jo6/pgeC upcH6t5FpAObeYs3ODQWppm5GF7pwabTaoBf9F0BKGhO6++oEG0oJu5a9fkEbh317gFV bTRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=EZqdBzvcEEhK2LCi9QdivWkqcm5il5dlaXo4uwGnfeo=; b=xftJXT6a4cSXtt6s/TRgkFHO1tOBxAMt1zKgLmtsx1JxOnnaY/ucVdARsSuOA9Z/mM iWPWZQ9a5UyRNCmHnFjLUAtHH5FQl0dTj61iJlaThqEJrOnrpyhsVEbxdBoHDmj8pazs NIGZBaxAg4l6YxPm4z+KtYO7I/CgTnONM/VnJhYAEkvviG4EeHSRLIAz5NU6zbmwjjhB wCPIYM1dKZTPPw+IZBOIhDiXMDl4zu1CjWOd3sgnJ/CmeRBaZ4lKww0n1ys52orOiHWE mMSEvQyY5kaRWyuk7zxrQck+AgSUuDLgBbKv19badO6PrrygXUsZradjFsY3CrPjABCa NshQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si3271262pjq.79.2019.05.30.12.30.21; Thu, 30 May 2019 12:30:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbfE3T3J (ORCPT + 99 others); Thu, 30 May 2019 15:29:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:58828 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbfE3T3J (ORCPT ); Thu, 30 May 2019 15:29:09 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4312914DA812D; Thu, 30 May 2019 12:29:08 -0700 (PDT) Date: Thu, 30 May 2019 12:29:05 -0700 (PDT) Message-Id: <20190530.122905.427002960025853686.davem@davemloft.net> To: rasmus.villemoes@prevas.dk Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, Rasmus.Villemoes@prevas.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: dsa: mv88e6xxx: fix handling of upper half of STATS_TYPE_PORT From: David Miller In-Reply-To: <20190529070158.7040-1-rasmus.villemoes@prevas.dk> References: <20190529070158.7040-1-rasmus.villemoes@prevas.dk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 May 2019 12:29:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Wed, 29 May 2019 07:02:11 +0000 > Currently, the upper half of a 4-byte STATS_TYPE_PORT statistic ends > up in bits 47:32 of the return value, instead of bits 31:16 as they > should. > > Fixes: 6e46e2d821bb ("net: dsa: mv88e6xxx: Fix u64 statistics") > Signed-off-by: Rasmus Villemoes > --- > v2: include Fixes tag, use proper subject prefix. Applied and queued up for -stable, thanks.