Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1293748ybi; Thu, 30 May 2019 15:05:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsk33H27S4KUonrbgfNBDqOdyoJgEo/pNt/ALd3TMfGZgoD351C0ujh8CWWbDFyshnN/Nu X-Received: by 2002:a17:902:e9:: with SMTP id a96mr5685175pla.37.1559253923010; Thu, 30 May 2019 15:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559253923; cv=none; d=google.com; s=arc-20160816; b=MM9K7dZfs+vPyCFrAh7xqSzDvLbynAB/g5qumkYQKQtWm+CiCok3ANUsTKOKzw6An5 kNcNDvEuTvWykmGA7/dpoen5ej01J9OaTY9OIHlPcbKJ0DY8c78A1ipKLzreJvwZ7RZ9 9SRORLhiQNhx0u4t6nFp2Yus9rJhEy6BUFzI9+ngyQD9W7IoAFSxXggEuQZIWQoZRiUZ WZG/llIlqZUXdYpgmFZkudyRNfBwBla3SigQ0XigE+rta+rytyo2Rxcdyfu8FljqpgWq 0yYde7PcWMDppdeI1PvDW/fqIzEqQMUnF7PSOwDmgh4viCWFGiRFcM52kBjfyv7fWISG p+Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=rshlwrJpBzpf9YqE4kL1oI5ucE6IgkMKu05JGCizifI=; b=uG5emkYYgiSOe0RQoFRyVS0KJJy+yqZS9/RbNWADJ612kI4h8WJIFGBrqkEuPA5w/W Z2C6HWCnW3I4wCpLAbSj9ei1cNx+pH9TYON/KVh2hNT6KIFY1pHJIs9s37D1wJRLG3DL WyPTsGVtVXicJR9vKKUciDozXkO5CYDSMd+5fBg7MA6RGFSiHvxNOANVPdx5YUIMeWG1 OFMvWBCm5GRzHW4fMGjQTarBhFKRC7t9wonM+SNqAlx3kngb67JkGnIIYES7t2hexZyc KvEdFt0AHPpg8ic15CrELFwKLlUoQftImuz+0zMbwzB5WN7Ib3ABs1bjXReixeSAEtVD eyAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si4130285pgq.350.2019.05.30.15.05.07; Thu, 30 May 2019 15:05:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbfE3WDv (ORCPT + 99 others); Thu, 30 May 2019 18:03:51 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32870 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbfE3WDu (ORCPT ); Thu, 30 May 2019 18:03:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 090C814DB034D; Thu, 30 May 2019 14:26:26 -0700 (PDT) Date: Thu, 30 May 2019 14:26:26 -0700 (PDT) Message-Id: <20190530.142626.1471109804622294121.davem@davemloft.net> To: tonylu@linux.alibaba.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, laoar.shao@gmail.com, songliubraving@fb.com Subject: Re: [PATCH net-next 0/3] introduce two new tracepoints for udp From: David Miller In-Reply-To: <20190529130656.23979-1-tonylu@linux.alibaba.com> References: <20190529130656.23979-1-tonylu@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 May 2019 14:26:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lu Date: Wed, 29 May 2019 21:06:54 +0800 > This series introduces two new tracepoints trace_udp_send and > trace_udp_queue_rcv, and removes redundant new line from > tcp_event_sk_skb. Why? Is it faster than using kprobes? Is it more reliable? Are the events _so_ useful that they warrant a tracepoint and thus creating a semi-stable interface for tracing and introspection via ebpf and similar technologies? Again, you have to say why in your log message(s).