Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190530235101.3248-1-mcroce@redhat.com> <685e8554eed17eebc731d62336ef30eb44bd14f7.camel@perches.com>
In-Reply-To: <685e8554eed17eebc731d62336ef30eb44bd14f7.camel@perches.com>
From:   Matteo Croce <mcroce@redhat.com>
Date:   Fri, 31 May 2019 03:08:14 +0200
Message-ID: <CAGnkfhwYpDOn=dcN-ko1eFn+WTCW+MurcHsLUa3z6xCxs9j6HQ@mail.gmail.com>
Subject: Re: [PATCH] checkpatch.pl: Warn on duplicate sysctl local variable
To:     Joe Perches <joe@perches.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andy Whitcroft <apw@canonical.com>,
        Kees Cook <keescook@chromium.org>,
        Aaron Tomlin <atomlin@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 31, 2019 at 2:55 AM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2019-05-31 at 01:51 +0200, Matteo Croce wrote:
> > Commit 6a33853c5773 ("proc/sysctl: add shared variables for range check")
> > adds some shared const variables to be used instead of a local copy in
> > each source file.
> > Warn when a chunk duplicates one of these values in a ctl_table struct:
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -6639,6 +6639,13 @@ sub process {
> >                                    "unknown module license " . $extracted_string . "\n" . $herecurr);
> >                       }
> >               }
> > +
> > +# check for sysctl duplicate constants
> > +             if ($line =~ /\.extra[12]\s*=\s*&(zero|one|int_max|max_int)\b/) {
> > +                     my $extracted_string = get_quoted_string($line, $rawline);
> > +                     WARN("DUPLICATED_SYSCTL_CONST",
> > +                             "duplicated sysctl range checking value '$1', consider using the shared one in include/linux/sysctl.h" . $extracted_string . "\n" . $herecurr);
> > +             }
>
> why is $extracted_string used here?
>
>

Right, it's always empty. I'm sending a v2.

Regards,
-- 
Matteo Croce
per aspera ad upstream