Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp248775ybi; Fri, 31 May 2019 00:31:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzOcQaGtPuZq2tL5pCeE8yz2R6xkaNqeeNTo4jdM+X1PSPhoPtI6V0jyRbnkPWbLRbqoI4 X-Received: by 2002:a17:90a:650c:: with SMTP id i12mr7718974pjj.44.1559287892360; Fri, 31 May 2019 00:31:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559287892; cv=none; d=google.com; s=arc-20160816; b=fF8WG2bsX/8GsHkRlMX8kj5qr6uKPKN2HB7wjxYwEI2mgdYlqDIaAa8ZlzE2J9luFg GOq3Pv9xSpZIQaRgcPyhwYC209zLXwvOGhwtNZOjrk/k1ieJKch01mF+t7vVyFe8o8lk JXVz2OyYWF4Oh+ihQ8e4o9JgpHHSXZpD5s3SPFUFDkP12JnwoZxysZ6k49aoEhoYhr/3 ASsGlriOFg7/07Q0HxDZQEbsYSY56HVoLPU2FLm4cLJ18AXuPoz16UGsPjBujLfhl4gn ggxELAE/3mUqAkm5BUxIZGUuOiFhIpiZ0qNhJ75y1Hsd4vo2h00zbwhczsysQuVhkRNZ jZ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vzsXDhTFEAJo81jN0j11kc9VOoYnu0zoDes9F1KBfN8=; b=RgMUTmmB87u4fDK6Y7W0DCTflO8dVVXFCLXzHpCNfiZ+DDnWsuShYpx4TD8Spht2oF W5rVW7bu7+3zeFdf2e4mUxHg5+7zJtyJOt7vS6mOjuaXoD7h5NW3SKaWcIvwINA9Yayv miGVyzeRw6RJV2QNFBGPp27xkUAoU9LzfyskMsPww9LQEk/HZeJYe1uJVXyajhMXOTVi Z35GwYwFhL24H6M8Io1P1VimwPMiZ4WKYIbbchUIUqLIyt1KlemLoYA2ZHIx/TxB6dNT 3lrVZOcxNMcqnqlFyG4gpyf4mp3wOEBzDAaCLiAnmIWBUKqqgXRKf2G5/fAsJ3K3wjjk CBrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mTrEKnP3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg17si4788900pjb.75.2019.05.31.00.31.14; Fri, 31 May 2019 00:31:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mTrEKnP3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfEaH36 (ORCPT + 99 others); Fri, 31 May 2019 03:29:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:42208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfEaH36 (ORCPT ); Fri, 31 May 2019 03:29:58 -0400 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E55FA264E7; Fri, 31 May 2019 07:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559287798; bh=Sx1m5/E8D/5A8KuMvDlpJkX5r56naO8qUsBat8C+qgk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTrEKnP3igGNFyinU5WlegALoxSzHevTxDMhvJML01Fxvds9diY9kGh0ptqTEVba6 jZt+kT6htNw5fnBs9nk4d0FTlH5KiAWoPM3Y6WcCd31Ggzsfzo/Mgb3lVBrxVqA5jx jhOcrry6DTnI5nrlsGw61OpHny4D+zMtZFL6SIw8= Date: Fri, 31 May 2019 15:28:33 +0800 From: Shawn Guo To: Daniel Baluta Cc: Fabio Estevam , Daniel Baluta , "mark.rutland@arm.com" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , Anson Huang , "S.j. Wang" , Peng Fan , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "m.felsch@pengutronix.de" Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Message-ID: <20190531072832.GC23453@dragon> References: <20190515144210.25596-1-daniel.baluta@nxp.com> <20190515144210.25596-3-daniel.baluta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > > > > + simple-audio-card,codec { > > > > + sound-dai = <&wm8524>; > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > interface, not an external clock that feeds the codec. > > > > > > It seems you should remove this 'clocks' entry. > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > the representation is correct: > > > > Reviewed-by: Fabio Estevam > > Shawn, > > Can you have a look? I cannot apply this one, because there are '=20' in the patch content. Shawn