Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp350895ybi; Fri, 31 May 2019 02:29:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqygtwUxzylJD9kjSdoOf+p+HMNqMGYJh31OlK7fwnm+FBriaU8WsLZdskXdtjQGq1tv6NBO X-Received: by 2002:a63:4104:: with SMTP id o4mr8099113pga.345.1559294969415; Fri, 31 May 2019 02:29:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559294969; cv=none; d=google.com; s=arc-20160816; b=Zz5y9oCw6jvjSNwJc6WBMKhKwAwy0PlQDH2go5xhrSZiq5bvNCIv5iBz8nntSHxQQ1 iee9eDvKnOo5XCeiInIViIbknfnydJZBW4EOVUGCK1FWQwWXDqDIBwNVm+XSDstcPq1L lbhq5HfavWHgbiH0FZb1hOR4sMCodD4NvDBm6uCRw07daE4xAgyvOQdBG1suDnNCoq7o 56+IAhQTAwqBK+CU5WxnMJJoQgv5oXdjsC0PfuTLJ2IUS1R5O8YxQspCbXLpw2OhCSyr 3iUqF/9dCnoZS6Ua5cjnw+fLCZPwIGfwrosHhEVMCqlPdL+IbEIAA3cAVLRal+Zjm0O5 0kJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature; bh=6ORWUZSng2vIxCnP1OnSqzrWksoaevXCFC29gecxJvk=; b=g4sDafqO4dGImu1bJ3zyEVqs91OVdR3CcqWMHjkwgKKHrlQCgNUJuuaK1vDpJQnxo4 GueJ6gsNw/fK3zBC/FJA8UyaXaQbEYwDWLFN5yaD2k9otcAE8fBX03lKqRWiTw6I4dos kydjOtRVpGV/usPH/wi/+egYgRpIjZlCK/e3i+tWSJ9KxUb1c99new1NtybUUmVAhrdy wWvTINrEXUbAddxize+1EpimKrtN3+P1Y0X+VDVSaZWyFBCpEvkxH0p6n3L+HtGW40A5 YdfCtgIM4tHMqdktbg7P+ynnRthuCLwi908ePIlpWN1iQWPryt4WiyCuWhj3e7nN4v19 unnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rRXvqsqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s73si4424192pjb.32.2019.05.31.02.29.12; Fri, 31 May 2019 02:29:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rRXvqsqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfEaJ14 (ORCPT + 99 others); Fri, 31 May 2019 05:27:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfEaJ14 (ORCPT ); Fri, 31 May 2019 05:27:56 -0400 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 487E6266D4; Fri, 31 May 2019 09:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559294875; bh=8ioYcrS5zNqXZCoF0MDDoNs+KB/u0y2k7wiOQtbqdwU=; h=From:Date:Subject:To:Cc:From; b=rRXvqsqSkMv+5uNcjorixP9OQ/A9sXvcIolEmFXXDeJ0CIPy1MWNSPlgFkijG/xDd JLwudD1WDqmIng8QTmERVwdvFX1+RZboJZoyqYg26krjFNoXZCPXrLfUr9vJmOeYBH jSzTqQJwf6ZuGH1Uu7nuHnO6o35ipNSPEYWqjxow= Received: by mail-lf1-f51.google.com with SMTP id y13so7330007lfh.9; Fri, 31 May 2019 02:27:55 -0700 (PDT) X-Gm-Message-State: APjAAAUPKOt7Prp5M9llPrgw6JEfVNjMsnrX4cqY+ocuXmECW1F/toHx 3gz+u+RniTMCBVlxB74hWWGgi11W6xgaG42E77Q= X-Received: by 2002:a19:4f50:: with SMTP id a16mr4880904lfk.24.1559294873357; Fri, 31 May 2019 02:27:53 -0700 (PDT) MIME-Version: 1.0 From: Krzysztof Kozlowski Date: Fri, 31 May 2019 11:27:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: [BISECT] No audio after "ASoC: core: use component driver name as component name" To: Mark Brown , Tzung-Bi Shih Cc: Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , "linux-samsung-soc@vger.kernel.org" , Sylwester Nawrocki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bisect points to commit b19671d6caf1ac393681864d5d85dda9fa99a448 Author: Tzung-Bi Shih Date: Wed May 29 14:22:14 2019 +0800 ASoC: core: use component driver name as component name as a reason of failure of missing Audio card on Odroid XU3 board (ARMv7, Exynos5422, max98090 codec). Full kernel log: https://krzk.eu/#/builders/1/builds/3349/steps/14/logs/serial0 The problem might be in component name. The driver->name and fmt_single_name(dev, &component->id) are: snd_dmaengine_pcm != 3830000.i2s snd_dmaengine_pcm != 3830000.i2s-sec samsung-i2s != 3830000.i2s This commit should not go in without fixing the users of old behavior... I could adjust the platform names for primary and secondary links... but now it looks like two components will have the same name. Best regards, Krzysztof