Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp401255ybi; Fri, 31 May 2019 03:21:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9yoLyVKNfkR0Z+TOG/qBFwEjb1awIY5YXdK5x7Lb52g62tklPhqYKmvnFKw3fMYjlf/95 X-Received: by 2002:a17:90a:9385:: with SMTP id q5mr7930780pjo.126.1559298112451; Fri, 31 May 2019 03:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559298112; cv=none; d=google.com; s=arc-20160816; b=c/iGRRpb6ROAcYjfdPLbeNJ1GM1aHzMmJNzYG0wDFsc29SDiijUNC8P3B/ZUE4flm+ xJ5hug6smCN/d+nLqQ1ThuR2eU5D6j1rGQVvRGvWuqJTJcFu/V0/XnnAX9DxZSAsEQzK CU7BYWmQe8ZVxWeLcy+rzJESG6BSc4qyTSGt2VGpGaQp3tU97IgceGtYoBK756yeGwKE QY1Aer9rsit+6NOD4oppIeFsNo4Wb1wI0zxx/tDEKb1+EkIui0FwvjZmiz7owyAI0f/M 6Bxxs/KoGZWyQKiRf+u2/TVrmJuM82O83arfNOsT/urGRrEZEiA8ZHV0fGMmZo2oPJyX DcJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=iy+b2XmhA0ntKME0CnMJCgRk0OfnARxxHVb5nAyoOQI=; b=hNPF8/LO3vMibw8ABymvLAXQiH9WVVogTGNjpADpb4b+mr3Q7WPLPi5v3qJefQjTN4 zyGZUqeN91TSEG/m4Oa8Fb7i13C9LO5ueflMKt6rIkP+1Jb9rEoOxsscJ+JwAeIbUeun ep+nU4u0kGVJH9oIyumFGR0j3Ebj+MxFTDYBzTIaU8gxvfmeSrOAXn20Q+7IVWclgHAZ 9Kii0tdW+cI3ypfNmrZ/kEZrdypFjKvRxwmP+KVUwdtOWMQQ0TBhxgNSwP+EI1TkZNQl +M9yAkjZ0jDUqdtSAdO6zKS7dSgW/aMJE8J6dEvwGvIPopqORuPmh1YWegz/jEvdHSNN lCzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NsM6Ojtr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si5292569pgv.230.2019.05.31.03.21.34; Fri, 31 May 2019 03:21:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NsM6Ojtr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726626AbfEaKUP (ORCPT + 99 others); Fri, 31 May 2019 06:20:15 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:44869 "EHLO mail-oi1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfEaKUP (ORCPT ); Fri, 31 May 2019 06:20:15 -0400 Received: by mail-oi1-f178.google.com with SMTP id e189so572970oib.11 for ; Fri, 31 May 2019 03:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iy+b2XmhA0ntKME0CnMJCgRk0OfnARxxHVb5nAyoOQI=; b=NsM6Ojtr9vYMDTe1/mfRqJupLufihu+ZNUA0u/SNXUiXRqSs5vzhrg6EJCVVp47vua csDeujruhQ52gKRcsDzg+TNOyATTyYrEUPZRQ8CgvxuRfHVTHBESoi3M3caz1MktLeeQ gcOjC16+wZ4tOKU/esGTXt7IbhtV7MP+3F1fWGcWV1+EIoEGDKhrYgu/QmFjCFPPAYJx fM5KFxta5mP1FY4t9E8EFGCQC1DGAtEaRVK2khkPqqm7xE+4dZ8N/K6EOVG5xlUlyHUg Iretlr5BJIcYk+L+LCNn4iNJwpmrX9suAxk4syrbuBbPMFc+6dDd+Hy/FiI8feCuByOK 7M+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iy+b2XmhA0ntKME0CnMJCgRk0OfnARxxHVb5nAyoOQI=; b=BLTvkQpBRh1ps9zH00t2EhYI+Hdye7qVQDduMEteu1ob2MGgUXjYtX4scXd8rmUgOy oeG5sAvY6GID1NzazTD7QOx2vSZxT/rgRWj6QgQtCNih95rw8FGsRL2dcJa/FQ81RRxJ i8v2XoymjrQKl8wEborbEh6ChmGWCMZ36OBqule2fFmkkgnmmkfrWlxD08+YLEOkHWDA ++9HdYp+TY9s2TmwttJDNmcy2GJ/aZiPU0O2hMNT/k4dJxcmWRbynt3H+VZFrD5Rih31 zCvsytcnvz/XrzaMcxWqyEtzM1nzXazWqDvaNN+2+XBQBySR3NgGouLgoyVvVdGZtEWj UYYA== X-Gm-Message-State: APjAAAWwoVDx6kqvFbEBCjIky/3//iykEAUGGPcEuP5HYN8XB8e1QDax +bEy0Jc8WgAUB9j33UC+D6iEyjquspFv3acptYY7MA== X-Received: by 2002:aca:80e:: with SMTP id 14mr5832960oii.2.1559298014153; Fri, 31 May 2019 03:20:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tzung-Bi Shih Date: Fri, 31 May 2019 18:20:03 +0800 Message-ID: Subject: Re: [BISECT] No audio after "ASoC: core: use component driver name as component name" To: Krzysztof Kozlowski Cc: Mark Brown , Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , "linux-samsung-soc@vger.kernel.org" , Sylwester Nawrocki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 5:27 PM Krzysztof Kozlowski wrote: > The problem might be in component name. The driver->name and > fmt_single_name(dev, &component->id) are: > snd_dmaengine_pcm != 3830000.i2s > snd_dmaengine_pcm != 3830000.i2s-sec > samsung-i2s != 3830000.i2s > > This commit should not go in without fixing the users of old > behavior... I could adjust the platform names for primary and > secondary links... but now it looks like two components will have the > same name. That is because the two component drivers used the same name in somehow. But yes, we should not have the commit without fixing potential errors for users depend on old behavior. Could you send a patch to revert the commit b19671d6caf1?