Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp421368ybi; Fri, 31 May 2019 03:42:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwICq+txnrnyVFyC4ngOkoU0NvWyl4uid/6gB5AEHLcGrT8DCeA5nJ8qU+wvCzb1xDJexqR X-Received: by 2002:a63:d949:: with SMTP id e9mr8162049pgj.437.1559299325573; Fri, 31 May 2019 03:42:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559299325; cv=none; d=google.com; s=arc-20160816; b=STkmRQmiUotkvZyueHIWLkx0FEMOGyY7/bRqWyuINaSFuI2uIwIRwlN3dVvgYVT6Ot jDG6M8hOFoLZFkYlYZIQxFowg3FyqAH5QnWZE/qlVM0nf+yEqzqBVDLZYeLUqeZNyb6h QP9hZGexnakJxd/uijWmsye0eSI3i2FEomu/ieYPoblRTlepTSTaVdSF+1pnHLs5NI4X fnErpcRbkF9gN3W3Tc26YF9Pgq4/SEE+q1IBzHmDYTio2MHvWFFLXRX8oHWTz5oHsa9a Cv6Ac/QFsGhngrss1vAegMr/dtuuXyQsQqkqDoHzW+gMITyA2XfCDt1p9yhlUoAr4IJW chGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=KSjBhzyrlvziB4voZgXQbYUpz5iG34F9UOd+/42hGgY=; b=EIhCkdh8FfZ+OZUm9fbVBzpO/Y7LNgxDPBRnySkY20QEE/4f4H9RowDKf8VcbzvGzq utNUkytykwBK0u/60jEpBE14epnPRd1IejoiUAKHrYYEqsnFxi/N5dVP8LTHQGVhIJxX NO07/q1zrQubDyDzwYYJl/9u2Qt587VBZfQwCEzG5WitmV7gEPaF2sWqjRwKmVZOmFdL KeNXE3D70DBFUjUNYXpcfo2c2XcgQKl+CQ5ktf8Ewv6Mm8V5jF5gcMUuy48vX3yB0zaA WhEu18qk3TOBdOFNyPMkcMOHhF7DimvXiTDr9gccLYWDwureoWhg0aG17ujSB6z0bY0K yFRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si5453917pgp.529.2019.05.31.03.41.45; Fri, 31 May 2019 03:42:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfEaKkd convert rfc822-to-8bit (ORCPT + 99 others); Fri, 31 May 2019 06:40:33 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:54113 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726002AbfEaKkd (ORCPT ); Fri, 31 May 2019 06:40:33 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 16746809-1500050 for multiple; Fri, 31 May 2019 11:40:31 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Colin King , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Matthew Auld , Rodrigo Vivi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20190531103201.10124-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190531103201.10124-1-colin.king@canonical.com> Message-ID: <155929922781.27302.13050993726222660588@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr Date: Fri, 31 May 2019 11:40:27 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Colin King (2019-05-31 11:32:01) > From: Colin Ian King > > The assignment of err is using the incorrect pointer vaddr that has > not been initialized. Fix this by using the correct pointer obj instead. > > Addresses-Coverity: ("Uninitialized pointer read") > Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client") > Signed-off-by: Colin Ian King Reviewed and pushed, thanks for the fix! -Chris