Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 31 May 2019 15:27:00 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     kernel list <linux-kernel@vger.kernel.org>,
        dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org,
        teheo@suse.de
Subject: Re: devm_* vs. PROBE_DEFFER: memory leaks?
Message-ID: <20190531132700.o7kopr33kdztqdv6@earth.universe>
References: <20190531085209.GA20964@amd>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sfcqqzyrmfnzli66"
Content-Disposition: inline
In-Reply-To: <20190531085209.GA20964@amd>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--sfcqqzyrmfnzli66
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Fri, May 31, 2019 at 10:52:10AM +0200, Pavel Machek wrote:
> Is devm_ supposed to work with EPROBE_DEFFER?

Sure.

> Probe function is now called multiple times;
> is memory freed between calling probe()?

Yes, EPROBE_DEFER is an error code, so devm resources
are released.

> Will allocations from failed probe()s remain after the driver is
> inserted successfully, leaking memory?

devm_ is connected to the device, not to the driver.

Since code is better than words, check drivers/base/dd.c yourself.
The relevant function name is really_probe(), interesting part for
you starts at ret = drv->probe(dev) line.

-- Sebastian

--sfcqqzyrmfnzli66
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlzxK6AACgkQ2O7X88g7
+po8XhAApEXxQhcTweD9Ef8YuyoQm7NGIQl1kT6QV+Mg9vDgyf4wvowZDEcInCMd
Em2OCVHoO6QBEnmq8yci4a1l1hpppH3a7MugZKGBRdS9t1f0tBMdyE5dpU5xYmWX
yPfV16JT6Duk47wxVN53DhjNZlpYNVCQL4ok6crOlJWwp3JvfG+GZVXpuEZ+0md5
Qo1iQWVYsOnVljBgKTeQ4ZkcjeRqrUIB7OcJJ4jmV2/t2JurtYr2C9u7BCnG26CC
AuBUE5wWQtq30HS79jF0/b9F2sVu2QLf9vfCRt8mayTA+pi3e6qoYsYrvkHOTjTF
PuJGb1oxgrJ2YSZm+R0q7GRZIwB2twV3LgTghImzHP85rX3uo8KvJPvbkyTYNMfk
NspgQCcJAuNNNRH9rRkMLLuWTx2lCC77mWxNUwfHBltDIphT/3m+JRsnW6VdgA/T
xR6yZ/q/ThQZQ0tCPxyEunry62fHbdllcRYCIwJ9CNKSnrO4kWLrDUqop8LUFlq+
b0bSYHHd3+CDT5379zQPlryIlJKy9l2P0vTCwIFDKurOSX+Qi8APnpas4qjD0vAE
lPEoPoLUwqWefDbt1t90OSVJCggqIDoTH4q3aOLWPDwvNr4wFXHo7kW37ogwYr6F
FM22DHPQUqZqdNyLYnlxonn2h+959laOa0xYN8lR+y5IfrMvTek=
=K+Zu
-----END PGP SIGNATURE-----

--sfcqqzyrmfnzli66--