Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp754971ybi; Fri, 31 May 2019 08:27:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKsKQc2Gyg8UHlS8H1aIyWKJzdrtLMZmehFzLgZOr4AXL6AWlt1jKf9kRFVVJZRZSh/MVA X-Received: by 2002:aa7:8143:: with SMTP id d3mr7014817pfn.143.1559316424945; Fri, 31 May 2019 08:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559316424; cv=none; d=google.com; s=arc-20160816; b=DXUJFQdTys3dBGWuKEpeRBzxwS1t93mXe7MIm1oLL+Jq+LOPP9RFsSwaY6inHzIJtg CFLYi6FBoOhiPoJzGWm9u2mnIMXE2aztpZ+5u5jyXpvYzYFM/yuyLIwuMSanh8QSWvLW oDp6c/kcp9MnblCodL94jTo/RhrAED7t6lh5TWBSXWve0gfu6SVho54rgJbLJP0yvXC8 xlOy0G+GX2IipzrNp24Eh6wmQyTp/VqwAPTX5nmdYCilnEs5MiXKvqNNmbs02AqNBrQb 5uhCFPZdp0uEF7CWWXfq6otLy+Vk2sQt+XExg9huykEg/wsdmqkWWSGrfR4LJlONqfJC BfZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=e8c5tMf8c1zPdoyiHpusNVIokOzOgrs2k3irbl1JH34=; b=wfXtClKejBkZ9bc7KY3dEwjlBMIXsRiAD3ngDiISuqtRJzR90gPBlTxxbix+NcTtzs 2H+QBgejeuoey5GxrRBhANgQg42obf4c7vH2OyeCjX0a6oVl9f911GboQXZfLytcAy+s OuKWiriEsTv65SW/zqIFX5jKyaXXd3rkF8nrIkMdhX/P8xtwPBeLu7OsqNoPADjSbCVp Be/W/zAiYGrTMCW39Ghj4L8xDHbv/3ovd+OZB9QTdQdJhH9wwL2OLXaoYuUfVkz4/bvS IfkvPHSIjsNjELqgqV+9anAktA32NsdWr+n+utEFQSM/vgD6bt6ax1YgBMskD1ZTwlfW Ol/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si7095160pld.90.2019.05.31.08.26.48; Fri, 31 May 2019 08:27:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbfEaPZd (ORCPT + 99 others); Fri, 31 May 2019 11:25:33 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:54883 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfEaPZd (ORCPT ); Fri, 31 May 2019 11:25:33 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id E99063C0149; Fri, 31 May 2019 17:25:29 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JaAOyY00n-fj; Fri, 31 May 2019 17:25:23 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 06FB03C0022; Fri, 31 May 2019 17:25:23 +0200 (CEST) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 31 May 2019 17:25:22 +0200 Date: Fri, 31 May 2019 17:25:22 +0200 From: Eugeniu Rosca To: Geert Uytterhoeven CC: Spyridon Papageorgiou , Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Tobias Franzen , Biju Das , Eugeniu Rosca , Eugeniu Rosca Subject: Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837 Message-ID: <20190531152522.GB28755@vmlxhi-102.adit-jv.com> References: <20190411124102.22442-1-spapageorgiou@de.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.72.93.184] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, We appreciate your review comments. On Tue, May 28, 2019 at 11:19:04AM +0200, Geert Uytterhoeven wrote: [..] > > + wlan_en: regulator-wlan_en { > > + compatible = "regulator-fixed"; > > + regulator-name = "wlan-en-regulator"; > > + > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > So this is a 3.3V regulator... > > > + > > + gpio = <&gpio_exp_74 4 GPIO_ACTIVE_HIGH>; > > + startup-delay-us = <70000>; > > + enable-active-high; > > + }; > > }; > > > > &can0 { > > > @@ -273,6 +298,30 @@ > > status = "okay"; > > }; > > > > +&sdhi3 { > > + pinctrl-0 = <&sdhi3_pins>; > > + pinctrl-names = "default"; > > + > > + vmmc-supply = <&wlan_en>; > > + vqmmc-supply = <&wlan_en>; > > ... used for both card and I/O line power... > > > + bus-width = <4>; > > + no-1-8-v; > > ... hence no 1.8V I/O. > > However, VIO of WL1837 is provided by W1.8V of regulator U55, > which is 1.8V? Looking at the KF-M06 schematics, it seems like the SDIO-relevant lines of WL1837 (U52) are interfaced with the SoC via TXS0108EPWR (U57) which is there to level-translate from 3.3v (SoC) to 1.8v (WL1837). So, from SoC perspective, it looks like the lines are 3.3v-powered. FTR, the test results are independent on the 'no-1-8-v' property. > > + non-removable; > > + cap-power-off-card; > > + keep-power-in-suspend; > > + max-frequency = <26000000>; > > + status = "okay"; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + wlcore: wlcore@2 { > > + compatible = "ti,wl1837"; > > + reg = <2>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > > I'm also a bit puzzled by the interrupt type. > On Cat 874, it's IRQ_TYPE_LEVEL_HIGH, cfr. > https://lore.kernel.org/linux-renesas-soc/1557997166-63351-2-git-send-email-biju.das@bp.renesas.com/ > > On Kingfisher, the IRQ signal is inverted by U104, so I'd expect > IRQ_TYPE_LEVEL_LOW instead of IRQ_TYPE_EDGE_FALLING? That's an insightful comment, if it simply arose from code review. I guess we mistakenly relied on [1] during our testing on linux/master. So, we definitely have to re-spin the patch to make it independent on [1]. The problem is that by dropping [1] and switching from IRQ_TYPE_EDGE_FALLING to IRQ_TYPE_LEVEL_LOW, the wifi testing (particularly 'iwlist wlan0 scan') doesn't pass. We have to give another thought how to best tackle it. [1] https://github.com/CogentEmbedded/meta-rcar/blob/289fbd4f8354/meta-rcar-gen3-adas/recipes-kernel/linux/linux-renesas/0024-wl18xx-do-not-invert-IRQ-on-WLxxxx-side.patch Thank you. > > Apart from the above two comments: > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Best Regards, Eugeniu.