Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp838460ybi; Fri, 31 May 2019 09:35:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3Yyhsbzix5AAkwFreS6ggAUNgnW8ikQXkgo/G0slrX9eFmBBwPcqzb6y9o22uENOt577F X-Received: by 2002:a17:90a:207:: with SMTP id c7mr10458028pjc.94.1559320508721; Fri, 31 May 2019 09:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559320508; cv=none; d=google.com; s=arc-20160816; b=HHw1KyjtaToL/IKpUh0a2BgW3o6ACki+qeIHHD5EnTt6BdLZ5/7c3hFYuGyom7/d4n RkyYr0miSn02SE5E99VU9xJuECwVN5B9dn1zG5cXi7uxM+0nHr7Hy+2rLATmYllr3pFu vyiHtF8jqDCf6KQ0ICKb6YNXdkEVGwc2Z48j0n9+p5FZs6ZmFl04+XbC++3PET6AIGSQ tnZtrCHT2fwMUovsrvtF9VjlZdnGct10iKJ9K0uNvXFuVnHh4Wy0wVKYPd+6xeZB6VLW wPgP7D4dqO9EdhZiA1C+sPDGXkvCxp0b9Ou0uAK4iiPBdrfCZH8hdWsAr6933w+vXufb 4f/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=71MT+BROvQCbPstDEU/GSeEYIz2R3vLcby0U7n4LLfY=; b=gLdJ1PPbH/WZ3anT/34WFx8QADHYRx5XAvwG+MTrGGBP++obqNflW/Yc8uV0Nbrgh/ 4rOL54o1R9bYn8NkxK+rDEHmm/AeCm1DcNb4hRVW4ONsCdGX9JmnyqtCD4hXI4JTmlcY Z0Ejfhf8Nx20+IB+kDB30W9z4bnSddzqRCYysbh/N2iYY+zunL30KIgFAI80nAo1TaU/ DW0F5MaAbjDkiBUZd03q6evNDL4ZiofpD+MQcbvZ4cy8m6jRhvYQv/7Qc9D12727xovI n0CGYw8TgHfgV71qNJ3lepr71o3Gf58MS+q0MXudsQ8fq5uC9FnfcpM3cXfTlNRprz+e uT3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=KRm8qX1i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d125si6804590pgc.414.2019.05.31.09.34.51; Fri, 31 May 2019 09:35:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=KRm8qX1i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbfEaQcb (ORCPT + 99 others); Fri, 31 May 2019 12:32:31 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33888 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfEaQcb (ORCPT ); Fri, 31 May 2019 12:32:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=71MT+BROvQCbPstDEU/GSeEYIz2R3vLcby0U7n4LLfY=; b=KRm8qX1ifVr9clKQgPQOzBCIX 5tOQM22B22476qAO11z49POuV0WFuttFD147Sio3LcgfdkcNHLGLpRuCTgkvxXbCamh15MJCX7TwT pIRxuAEyJgKmVL2vlhOwM+Z93AtSS3/MhVMwIaZlFhMcfOsn7GOgd1/wSuA+wWLTY752BsJLEZ+Bu lkcXe/xe4BlysB2zjEEaMWjWuLlS1imej7I2WEaFy2y/woAEHj/8ViFu141ug5u8ey9ElaYvX1Rst 1oMgg0dyoHRukxYhLQlc1GeatYALHXRpBZDxVWuIfhb3B/llNOQfd8lw662bBJBIDZgnUOr/bJRBS FV/pugisw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWkSD-0003l4-C7; Fri, 31 May 2019 16:32:29 +0000 Date: Fri, 31 May 2019 09:32:29 -0700 From: Christoph Hellwig To: laurentiu.tudor@nxp.com Cc: netdev@vger.kernel.org, madalin.bucur@nxp.com, roy.pledge@nxp.com, camelia.groza@nxp.com, leoyang.li@nxp.com, linux-kernel@vger.kernel.org, Joakim.Tjernlund@infinera.com, iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 5/6] dpaa_eth: fix iova handling for contiguous frames Message-ID: <20190531163229.GA8708@infradead.org> References: <20190530141951.6704-1-laurentiu.tudor@nxp.com> <20190530141951.6704-6-laurentiu.tudor@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530141951.6704-6-laurentiu.tudor@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 30, 2019 at 05:19:50PM +0300, laurentiu.tudor@nxp.com wrote: > +static phys_addr_t dpaa_iova_to_phys(const struct dpaa_priv *priv, > + dma_addr_t addr) > +{ > + return priv->domain ? iommu_iova_to_phys(priv->domain, addr) : addr; > +} Again, a driver using the iommu API must not call iommu_* APIs. This chane is not acceptable.