Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1034350ybi; Fri, 31 May 2019 12:40:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzK+3AWy0qQgpv2nEbRyPQQpq2a1KWFoZunpRroPSbohZraJcZmk4oQ4w75bYZkUFRYKhzY X-Received: by 2002:a62:b40a:: with SMTP id h10mr12388573pfn.216.1559331643502; Fri, 31 May 2019 12:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559331643; cv=none; d=google.com; s=arc-20160816; b=joUVz0UiiXthCE4+B0i9AXnI4AFmRj/S389BxYm0aWyTJtN/qPTZxpbtnM1uSvUlJG 1kjoHzCr84B4a+6KUKCCm63xg2blTZv+brJocKQlcWjKPDj63LL8feLgePVynLgfdz5A NejNEr+FL0qU2UWLyOzX1naNL+YR9MEKrkKsAGWjZ8MvzH8yCLVgog9xsdVLDEg8UAOe wc1r/31ER3ad+GpdUDNjUY+mUVMJBpyyzQ0d/79xaBAML0CUITjgAImJR1D/o5Xx6k2h fc5dwGPWKwSonbnwJG4inttxkZaJwbjjDzZzANBFMZ8Sc/gpBN4tve6KAORtZrTNFpU+ zqYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2wFAyGY34pIc6i2kWmmGfhSp2W9UYdh3ehYxwjItuzI=; b=GqS1uuIBNO5u6eTX7onWGOyjHF3Z++cD1DO0TEsWBalvORqlTqHiUciw1w5d2Ju4CK jkegIXt00MTuENUW0SbL8S/ptygApQSP9E7S/aLHoJchZEq7qn7u0MKe3PMzcUxO+WQd PvMtIFUioB37MlFxa+IgpNZgWkTwgq5xRRZrp2+XCSJmWQxpkoSjbMzar4im3t5rzL5G 5Fx02IHYxsdAl43/RfHLZgOt94k0myTRBhRvbjqxb5/UQoCDz6ZhH0Xyd3jK9x66+3jE pzCe9fYd4HwquENpwDm7LJxZ9Swm6ZBfg6IehaSVcIo1IgqTXh1A+IGk0qRZEFgI9fTR +YeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7si8175911pfn.249.2019.05.31.12.40.27; Fri, 31 May 2019 12:40:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727299AbfEaTjR (ORCPT + 99 others); Fri, 31 May 2019 15:39:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33840 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfEaTjQ (ORCPT ); Fri, 31 May 2019 15:39:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 530FF3082201; Fri, 31 May 2019 19:39:14 +0000 (UTC) Received: from treble (ovpn-124-142.rdu2.redhat.com [10.10.124.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E257C5D9D1; Fri, 31 May 2019 19:39:09 +0000 (UTC) Date: Fri, 31 May 2019 14:39:08 -0500 From: Josh Poimboeuf To: Petr Mladek Cc: Jiri Kosina , Miroslav Benes , Joe Lawrence , Kamalesh Babulal , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] livepatch: Use static buffer for debugging messages under rq lock Message-ID: <20190531193908.nltikmafed36iozh@treble> References: <20190531074147.27616-1-pmladek@suse.com> <20190531074147.27616-4-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190531074147.27616-4-pmladek@suse.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 31 May 2019 19:39:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 09:41:47AM +0200, Petr Mladek wrote: > The err_buf array uses 128 bytes of stack space. Move it off the stack > by making it static. It's safe to use a shared buffer because > klp_try_switch_task() is called under klp_mutex. > > Signed-off-by: Petr Mladek > Acked-by: Miroslav Benes > Reviewed-by: Kamalesh Babulal Acked-by: Josh Poimboeuf -- Josh