Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Matt Mullins <mmullins@fb.com>
To:     <mmullins@fb.com>, <bp@alien8.de>, <mingo@redhat.com>,
        <luto@kernel.org>, <namit@vmware.com>, <peterz@infradead.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, <x86@kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        "Rick Edgecombe" <rick.p.edgecombe@intel.com>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        Douglas Anderson <dianders@chromium.org>,
        <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/kgdb: return 0 from kgdb_arch_set_breakpoint
Date:   Fri, 31 May 2019 12:47:54 -0700
Message-ID: <20190531194755.6320-1-mmullins@fb.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

err must be nonzero in order to reach text_poke(), which caused kgdb to
fail to set breakpoints:

	(gdb) break __x64_sys_sync
	Breakpoint 1 at 0xffffffff81288910: file ../fs/sync.c, line 124.
	(gdb) c
	Continuing.
	Warning:
	Cannot insert breakpoint 1.
	Cannot access memory at address 0xffffffff81288910

	Command aborted.

Fixes: 86a22057127d ("x86/kgdb: Avoid redundant comparison of patched code")
Signed-off-by: Matt Mullins <mmullins@fb.com>
---
 arch/x86/kernel/kgdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 9a8c1648fc9a..6690c5652aeb 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -758,7 +758,7 @@ int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
 		       BREAK_INSTR_SIZE);
 	bpt->type = BP_POKE_BREAKPOINT;
 
-	return err;
+	return 0;
 }
 
 int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt)
-- 
2.17.1