Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1085911ybi; Fri, 31 May 2019 13:39:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzXgXsKvYibKR5VSDiXK9Ynq5KsXtcVE+oY2+i1MgFuuzdrfMLYMoR4iCZ5+cTFJUD2i0d X-Received: by 2002:a63:eb0d:: with SMTP id t13mr11667100pgh.37.1559335186669; Fri, 31 May 2019 13:39:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559335186; cv=none; d=google.com; s=arc-20160816; b=tBbT+oN4lRxOOA67PiHx1/Y8CiOzD+xSeBsIGWJUXFMF52svheqExqy5Ushn3796GC etNLWAWbbQ4CG3zl4rMpB5Y0LbHz1u9WM8WV4YA45wFdmJ3/Gzsq1WN8SEHKGYXZQnkS 7bOvsiXghodVZYMjbA0x+VsZH8NFaA2xdAWMrGv9/TxIQbPmuYki0GcqPtVsar7ZrDOZ zTMXDEBGrBjw1DWFrXR1qpvng3Un8Xj14hkLuuAJ8hpnEM2Kx0ymDmFfufvTLo9q5geK gL5Z8UgBNbFPeFph15Qo9ZiL2wYwRD+GNwB4oLizbTdBldbpegJypM9jCQo+MmTfUszb vRQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :mime-version:subject:references:cc:to:from:dkim-signature; bh=aOESg6dc3jbmPoXHPMF+s4E+BmTMe8uF7HOOkbnQtDE=; b=vib/n6cke/y1ToaO8EjglXGXkJyTCvwzkqQ8F7hY3++hEp6lJIQvRXQ6WxeuDMXIoC 1aJrwmD0mZ5rkiKgWqtrooU2g1lu35Co4EI4I4s+r/R0lE8sbK9OG8H88m9uk7FrGfhW Ulxvy/+12F9hzdUJ3LyTLAkYFfIJrsq8tef91bkRIK5Xm3aj2B8KXlxnJWZqF2cVc3Lz O43AaBHllbkUzMRX87ZHS0Q6KwHuC+D7zLYwu//dkWsftFiwIw4O3x2uMtbW/QJ1+HgA vOJutOl27FRpt8LoCZfZgw5VwyAZCmwZB5K/1pA+dUuzJiWY6SGwxd+3YUebRtE1Xy1j 6Ufg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="v5/9XNia"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e8si6890176pgs.308.2019.05.31.13.39.31; Fri, 31 May 2019 13:39:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="v5/9XNia"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbfEaUiY (ORCPT + 99 others); Fri, 31 May 2019 16:38:24 -0400 Received: from forward500p.mail.yandex.net ([77.88.28.110]:47483 "EHLO forward500p.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbfEaUiW (ORCPT ); Fri, 31 May 2019 16:38:22 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 31 May 2019 16:38:22 EDT Received: from mxback15g.mail.yandex.net (mxback15g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:94]) by forward500p.mail.yandex.net (Yandex) with ESMTP id AEF9294021E; Fri, 31 May 2019 23:31:39 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback15g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id NSNA6E8kDg-VcHaliMO; Fri, 31 May 2019 23:31:38 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1559334698; bh=aOESg6dc3jbmPoXHPMF+s4E+BmTMe8uF7HOOkbnQtDE=; h=References:Date:Message-Id:Cc:Subject:To:From; b=v5/9XNiapzgSOdFGG8jyLT/DIzELyaVf4t4w7spq6rg8HbjtKxp8BF/qN78qE7sPp AMKxWuZkP0rspkDlKk03cjwPLK/NV/k2pBEMST2c8bcCg4pjrJUmNSfEhWlfTbW2dr IriyRwed5+DUabngfPbCo2OgheVZgLei28FiA690= Authentication-Results: mxback15g.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by myt6-add70abb4f02.qloud-c.yandex.net with HTTP; Fri, 31 May 2019 23:31:38 +0300 From: Andrey Abramov To: Joe Perches , "clm@fb.com" , "josef@toxicpanda.com" , "dsterba@suse.com" Cc: "linux-btrfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190531195349.31129-1-st5pub@yandex.ru> Subject: Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 31 May 2019 23:31:38 +0300 Message-Id: <14843931559334698@myt6-add70abb4f02.qloud-c.yandex.net> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 31.05.2019, 23:05, "Joe Perches" : > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote: >>  Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files > These uses seem boolean, so perhaps just use bool? I used int because you use ints (as bools) everywhere (for example there is only one bool (as a function argument) in the entire raid56.c file with 3000 lines of code), so with int code looks more consistent. Are you sure that I should use bool?