Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c7dd57c50690048c16722005bba1c47bcb3af750.camel@perches.com>
Subject: Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings
From:   Joe Perches <joe@perches.com>
To:     Andrey Abramov <st5pub@yandex.ru>, "clm@fb.com" <clm@fb.com>,
        "josef@toxicpanda.com" <josef@toxicpanda.com>,
        "dsterba@suse.com" <dsterba@suse.com>
Cc:     "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Fri, 31 May 2019 13:38:22 -0700
In-Reply-To: <14843931559334698@myt6-add70abb4f02.qloud-c.yandex.net>
References: <20190531195349.31129-1-st5pub@yandex.ru>
         <a7a2a7c70c2dcef122ddbe86eb84820fc4384c7e.camel@perches.com>
         <14843931559334698@myt6-add70abb4f02.qloud-c.yandex.net>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-05-31 at 23:31 +0300, Andrey Abramov wrote:
> 31.05.2019, 23:05, "Joe Perches" <joe@perches.com>:
> > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote:
> > >  Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files
> > These uses seem boolean, so perhaps just use bool?
> I used int because you use ints (as bools) everywhere (for example
> there is only one bool (as a function argument) in the entire raid56.c
> file with 3000 lines of code), so with int code looks more consistent.
> Are you sure that I should use bool?

That's up to you and the btrfs maintainers.