Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190531205926.42474-1-evgreen@chromium.org>
In-Reply-To: <20190531205926.42474-1-evgreen@chromium.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 31 May 2019 14:01:52 -0700
Message-ID: <CAD=FV=VuPNwr-NhvDjH3stU7jCPy_+Cz2z3qTtr5EO2ozxsjkw@mail.gmail.com>
Subject: Re: [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules
To:     Evan Green <evgreen@chromium.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        LKML <linux-kernel@vger.kernel.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Manuel Traut <manut@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Fri, May 31, 2019 at 1:59 PM Evan Green <evgreen@chromium.org> wrote:
>
> The manpage for modprobe mentions that dashes and underscores are
> treated interchangeably in module names. The stack trace dumps seem
> to print module names with underscores. Use bash to replace _ with
> the pattern [-_] so that file names with dashes or underscores can be
> found.
>
> For example, this line:
> [   27.919759]  hda_widget_sysfs_init+0x2b8/0x3a5 [snd_hda_core]
>
> should find a module named snd-hda-core.ko.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
>
> Note: This should apply atop linux-next.
>
> Thanks to Doug for showing me the bash string substitution magic.
>
> ---
>  scripts/decode_stacktrace.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index fa704f17275e..13e5fbafdf2f 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
>                 local objfile=${modcache[$module]}
>         else
>                 [[ $modpath == "" ]] && return
> -               local objfile=$(find "$modpath" -name "$module.ko*" -print -quit)
> +               local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
>                 [[ $objfile == "" ]] && return
>                 modcache[$module]=$objfile
>         fi

Reviewed-by: Douglas Anderson <dianders@chromium.org>