Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2389336ybi; Sat, 1 Jun 2019 15:32:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwENFGLlkHNAzXi1OY5MgE7cSSJnqclq/QBiFu4ZUGH50I4ZkL5SUxtTRypE+EHkjfDJF/1 X-Received: by 2002:a65:450b:: with SMTP id n11mr17954892pgq.174.1559428358821; Sat, 01 Jun 2019 15:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559428358; cv=none; d=google.com; s=arc-20160816; b=eFbcHeg4dlr120v0qzplwmqYt3p/0+YD/in39W0zNbiOc+c8W9VS0SWYzu4MM42IK9 2gvh5QpheBsTiSgFU/vAp7zDS7GFVxYrddZK77SxsfWcZVU9YelIHIx0ZNtdk4OXHEwS CziI7VzFHIg//WBg0T8GLsDe5uA36R0F/eAKdUxm/JAolY7AQ/v5UMAx0QgLeCqGfRZS xG7Y0T8/PqiqWN9rAUjF0p0KVkkBnYdJS3DPDfmNHfRrM/oFOIT83hh+Xqmo/uJcCF9Q w8IGCJg/2z71RN0DHfjKo/Fk7ooj1XD5XltcXnq/yQo28fW62Elnq/VI6GIlZYwv5Tie +KMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D3sdCrSta+1LinDxkJqXRJ9YdXWa10ctUItDBKvA25M=; b=oU5yq/qrr5sj0cLA7luoHIZwh3lDVjQ6idXd6kR3n7lVLUvzGrmzmN0BX/SfpCFQA/ PX4puYsoEPE89X5kRCYBf1lR2NUENU0CnU5EBlaMDNPEWzDbSeDJu1DI2N+tPykaZuX4 DTM5H2TsdpS/vGWXyRPBG/jzM8odPhYFJfm4xB5Cv/X4r0ub6tgk2c4wn9ctU+UxxXle xOaHji/bWqFmJZ1dAqRoMk8/RKrTHxi94aWckeA2opuqf0P4akwZxUPtSxNtci4rheV0 jUbRCZT8pBcSTYb6+Pg0v9H9enLAEy3jyoA5rhanUY+ZwmBYt2xXby80QekKP/a0TrZB xpoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gHAEz0W9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si13121465pfe.8.2019.06.01.15.31.41; Sat, 01 Jun 2019 15:32:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gHAEz0W9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfFAW17 (ORCPT + 99 others); Sat, 1 Jun 2019 18:27:59 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44250 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbfFAW1y (ORCPT ); Sat, 1 Jun 2019 18:27:54 -0400 Received: by mail-pf1-f194.google.com with SMTP id x3so2825174pff.11 for ; Sat, 01 Jun 2019 15:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D3sdCrSta+1LinDxkJqXRJ9YdXWa10ctUItDBKvA25M=; b=gHAEz0W9Uu6qrM4ChuzLYGhD2n+4olfOU6qtJoOTBMe07a7Pc4Kg4feW7OCrB0FNOD pQJX/g4h2kdJiFQw/ZIM4s5GiPaQM2j5/cGGfHCrCR2g/GZ5h0YzW+8SpyH7GWKKIGYX JsyoEKMQELkCHYwUEweS6UvTXF7q7XQ+nsWJs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D3sdCrSta+1LinDxkJqXRJ9YdXWa10ctUItDBKvA25M=; b=t6sz8ZxHFHGeJ2nWstO2Q2A38Z0/sUKGYpZjrWVp1j5PFinyE7BNOfRBT36YPUbYbN ve9vWDyOKelma4Q75ZWQl6eOrvZrVjXyLahAyx10j+y2mun1hv/ue8vhZPrDJsf7i/tN jBefZ6Ab/AyNamfnzdGtFOzbDhbsLZ2Esys04NK1jpdmx5DtLmkZoaIFELzlStxGi/6Y v+ESktYBFoB0gG88yZC2XGtO+BxWOasg717pgcsA59eIeh+vh+l2Q6EATsn2J23+FwEM qr6pz5o1ZCDSXxncMK/jFuQgAPulFeQ19sHia650IP4XNsl01T+fDWchCfkrP+lr0XjA ESpQ== X-Gm-Message-State: APjAAAWcptFJMe+xQIi5f5Nov2TXmU71Z576ezWEkn2PRQ8HUmd11fgt +w1g8sx/qXT0NBYBnsi5nJvyTyCxzsqh3w== X-Received: by 2002:a62:a511:: with SMTP id v17mr19913167pfm.129.1559428073227; Sat, 01 Jun 2019 15:27:53 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id t33sm9908018pjb.1.2019.06.01.15.27.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 01 Jun 2019 15:27:52 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Mathieu Desnoyers , neilb@suse.com, netdev@vger.kernel.org, oleg@redhat.com, "Paul E. McKenney" , Pavel Machek , peterz@infradead.org, "Rafael J. Wysocki" , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry Date: Sat, 1 Jun 2019 18:27:34 -0400 Message-Id: <20190601222738.6856-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.22.0.rc1.311.g5d7573a151-goog In-Reply-To: <20190601222738.6856-1-joel@joelfernandes.org> References: <20190601222738.6856-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Joel Fernandes (Google) --- net/ipv4/fib_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b298255f6fdb..ef7c9f8e8682 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -127,7 +127,8 @@ struct fib_table *fib_get_table(struct net *net, u32 id) h = id & (FIB_TABLE_HASHSZ - 1); head = &net->ipv4.fib_table_hash[h]; - hlist_for_each_entry_rcu(tb, head, tb_hlist) { + hlist_for_each_entry_rcu(tb, head, tb_hlist, + lockdep_rtnl_is_held()) { if (tb->tb_id == id) return tb; } -- 2.22.0.rc1.311.g5d7573a151-goog