Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190601144943.126995-1-alex_y_xu@yahoo.ca> <20190601162907.GB6261@kroah.com>
 <155941810155.1991.11907646865432946934@pink.alxu.ca>
In-Reply-To: <155941810155.1991.11907646865432946934@pink.alxu.ca>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Sun, 2 Jun 2019 09:37:43 +0900
Message-ID: <CAK7LNASoaiBCObeEPO-hcrg9ftsGq2QWXoG+R8TWv1z53HJvXw@mail.gmail.com>
Subject: Re: [PATCH] crypto: ux500 - fix license comment syntax error
To:     Alex Xu <alex_y_xu@yahoo.ca>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-crypto@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        allison@lohutok.net, alexios.zavras@intel.com, swinslow@gmail.com,
        rfontana@redhat.com, linux-spdx@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 2, 2019 at 4:41 AM Alex Xu <alex_y_xu@yahoo.ca> wrote:
>
> Quoting Greg KH (2019-06-01 16:29:07)
> > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> > > separator.  Stop.
> > >
> > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> > > ---
> > >  drivers/crypto/ux500/cryp/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Also, how did 0-day not catch this?  Is this an odd configuration that
> > it can not build?
>
> I had to run "make clean" to get the error.

I think this copyright block is ugly.


# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) ST-Ericsson SA 2010
# Author: shujuan.chen@stericsson.com for ST-Ericsson.

looks nicer IMHO.


-- 
Best Regards
Masahiro Yamada