Date: Thu, 17 Nov 2005 14:07:23 -0800
From: Andrew Morton <akpm@osdl.org>
To: vgoyal@in.ibm.com
Cc: linux-kernel@vger.kernel.org, fastboot@lists.osdl.org, ak@suse.de,
       ebiederm@xmission.com
Subject: Re: [PATCH 3/10] kdump: export per cpu crash notes pointer through
 sysfs
Message-Id: <20051117140723.3cd2e831.akpm@osdl.org>
In-Reply-To: <20051117132138.GG3981@in.ibm.com>
References: <20051117131339.GD3981@in.ibm.com>
	<20051117131825.GE3981@in.ibm.com>
	<20051117132004.GF3981@in.ibm.com>
	<20051117132138.GG3981@in.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 748
Lines: 19

Vivek Goyal <vgoyal@in.ibm.com> wrote:
>
> +	/*
> +	 * Might be reading other cpu's data based on which cpu read thread
> +	 * has been scheduled. But cpu data (memory) is allocated once during
> +	 * boot up and this data does not change there after. Hence this
> +	 * operation should be safe. No locking required.
> +	 */
> +	get_cpu();
> +	addr = __pa(per_cpu_ptr(crash_notes, cpunum));
> +	rc = sprintf(buf, "%Lx\n", addr);
> +	put_cpu();

I don't think the get_cpu() and put_cpu() are needed here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/