Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2575312ybi; Sat, 1 Jun 2019 19:45:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDHp9h01y6iCliiAhDN9CMYj0B9PmIpw7VdXtTU4rlA0JdViJcqOCPBgBrJliGmFrg8LDi X-Received: by 2002:a63:1b65:: with SMTP id b37mr19745052pgm.408.1559443559344; Sat, 01 Jun 2019 19:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559443559; cv=none; d=google.com; s=arc-20160816; b=qLmi63p6ucKDADF5A18ztJtypyQFhXaKce8EFTqziXRYtQNhWDpdS9MFNzVIofaQjS x36Pml4U/FqrduswylevuVwpf8yZ7fVC0e+OAFjvItDOyaU42o4l7LzT5aQtEw+gjxos 7wEA7kiRQN8GG+dEKNfzNvoMWdzyrc+nFbgv60zeiYIEDuhgDdPclwI6o+aOeMvbGMg6 2lgAWOtL7nXafoh9/7dIiwHytB9rinA79Li8OMxKHCCGuoIeC6qBlEkBoxflbD4RWsiq +47467Kr92I6NgFkJu+8F1wTst+K3iWS8736P4KoUI/rBTLvTMNEHtdXKYbVtC3k7spm eeZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oDgFVxtqmyuheJBaBVal/89zEZUMMHeUTsM4U/ki1FE=; b=MctFTU99u7wTsDoHCdkwPZEAqhZr3OGCh6yJxF5lH0RJi+Hn4C6l8zfATVqbUTLw44 p0YkFDCw9kRxRwyhOOISh9Kq7MRywbViyk28FH+VF0gnD63zcaGnZTE9+Biu5lkb47p8 5zdjY1AzvTUfs1mf3UL6AFXGL4ffTKq/DSw+EBEPPPKfRE3sCKw+csfvrDfEP2xBKXKn HAXgzRgzVxCwP39Yf735py0QwB2SDK4rhBg8/13zl3vTN7PRWrb8X8V1sDuO1ypeME7V y5qPwE08AFikZpYKgQsjZnJ5IZFPzn5dGbCL7lfkdMd2XwN0nHnxRbsSOi1KQYG0uUZx FlQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si14999033pla.121.2019.06.01.19.45.31; Sat, 01 Jun 2019 19:45:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbfFBCnk (ORCPT + 99 others); Sat, 1 Jun 2019 22:43:40 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:54054 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726601AbfFBCnk (ORCPT ); Sat, 1 Jun 2019 22:43:40 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hXGSt-0001lc-Pr; Sun, 02 Jun 2019 02:43:23 +0000 Date: Sun, 2 Jun 2019 03:43:19 +0100 From: Al Viro To: "Yan, Zheng" Cc: linux-kernel@vger.kernel.org, idryomov@redhat.com, jlayton@redhat.com Subject: Re: [PATCH] ceph: use ceph_evict_inode to cleanup inode's resource Message-ID: <20190602024316.GT17978@ZenIV.linux.org.uk> References: <20190602022546.16195-1-zyan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190602022546.16195-1-zyan@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 02, 2019 at 10:25:46AM +0800, Yan, Zheng wrote: > remove_session_caps() relies on __wait_on_freeing_inode(), to wait for > freezing inode to remove its caps. But VFS wakes freeing inode waiters > before calling destroy_inode(). *blink* Which tree is that against? > -static void ceph_i_callback(struct rcu_head *head) > -{ > - struct inode *inode = container_of(head, struct inode, i_rcu); > - struct ceph_inode_info *ci = ceph_inode(inode); > - > - kfree(ci->i_symlink); > - kmem_cache_free(ceph_inode_cachep, ci); > -} ... is gone from mainline, and AFAICS not reintroduced in ceph tree. What am I missing here?