Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3685012ybi; Sun, 2 Jun 2019 21:02:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTTEht/sdu2P0VWzrxtdylxCi4m2bbxTQe7QUzqmMreYW/vDFDfqCxaouH4GHZFQwj89DA X-Received: by 2002:a63:6e48:: with SMTP id j69mr25676953pgc.34.1559534578061; Sun, 02 Jun 2019 21:02:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559534578; cv=none; d=google.com; s=arc-20160816; b=JMDSkUb1384MAYGOMdnDxFIIJjQ50foSXHFAluaTWBE0lBa67wbXYz71Tef6V4PfS2 SZZmGi1o+cEunvCd7yqO1MG6M6/nkKlUg5lJanFWVwhd1oYW6H2M06GzUywk8PyLyg0p h2C8HQaW1H74GlxpU7svXouBgp4Zd/BtIoX1RlGNqzZmhJBX1nEr+N31T8t53iZ7jPrl n30zn/5fHsizPC4o+ddr9n8cTFfgW3YA1tlIUdzIq7glICjafpUQU5m3xijlzC0p4Yrf 0yusLnsdKz4TpbHgPQNDvX58/kX0kzpx4eYGGXbar5FFKmBekbQSDaXEJBGPYtmiRd52 rizw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PHOsjhUj7MzZHV6hpOCML92jplM0FV3YKtPYWWDgYzo=; b=ZUQj/lTxfkrfQXk3Z8a9X5Kw1ior1WOSeCfTGUY8Hjk+JAQQDXj+4l2TjG215C+QEr flgp3Jzv0BOtQQqfLC9XKcLAIiaa2N9XuivN87fHVk6cHYn4a8UlwLGldWbAduayTJ7h 4ihobXvlHVW2Qt31MBHv4NTWHdYs/N6HVYfg6GZf9Cih0FU1w3ns45YhJYu4OHN0CRGL vt4pRwoYFKYDBfJpPdT1sZgPon5/1ToZQYRsVvAlvJrzRASaghPzii8qflD1GVNEuJ5I htIYx4OGAraVAWAVliI+NhYwlUL/X24gBZ2bxQtFaScSXltN9qRx9cbNJi1Vmy3tcS5Q MPXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20si16595218pju.92.2019.06.02.21.02.39; Sun, 02 Jun 2019 21:02:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbfFCEB1 (ORCPT + 99 others); Mon, 3 Jun 2019 00:01:27 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:47486 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfFCEB0 (ORCPT ); Mon, 3 Jun 2019 00:01:26 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hXe9w-0000BY-Iu; Mon, 03 Jun 2019 12:01:20 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hXe9q-00024t-Qt; Mon, 03 Jun 2019 12:01:14 +0800 Date: Mon, 3 Jun 2019 12:01:14 +0800 From: Herbert Xu To: "Paul E. McKenney" Cc: Linus Torvalds , Frederic Weisbecker , Boqun Feng , Fengguang Wu , LKP , LKML , Netdev , "David S. Miller" Subject: Re: rcu_read_lock lost its compiler barrier Message-ID: <20190603040114.st646bujtgyu7adn@gondor.apana.org.au> References: <20150910005708.GA23369@wfg-t540p.sh.intel.com> <20150910102513.GA1677@fixme-laptop.cn.ibm.com> <20150910171649.GE4029@linux.vnet.ibm.com> <20150911021933.GA1521@fixme-laptop.cn.ibm.com> <20150921193045.GA13674@lerouge> <20150921204327.GH4029@linux.vnet.ibm.com> <20190602055607.bk5vgmwjvvt4wejd@gondor.apana.org.au> <20190603024640.2soysu4rpkwjuash@gondor.apana.org.au> <20190603034707.GG28207@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603034707.GG28207@linux.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 02, 2019 at 08:47:07PM -0700, Paul E. McKenney wrote: > > CPU2: if (b != 1) > CPU2: b = 1; Stop right there. The kernel is full of code that assumes that assignment to an int/long is atomic. If your compiler breaks this assumption that we can kiss the kernel good-bye. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt