Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3733376ybi; Sun, 2 Jun 2019 22:17:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq95Svc9a0U68XAALMA69t3kvZeLi5maaAoz5urZ9NvoiIqRraBu2GH6CsrNBgzUFZAr4U X-Received: by 2002:aa7:9203:: with SMTP id 3mr29313865pfo.123.1559539067817; Sun, 02 Jun 2019 22:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559539067; cv=none; d=google.com; s=arc-20160816; b=W7XlKJHtnRyN7pbdWKBYxwO13haJ69V4roznhQZ1kSDIWyoenSUR9fLxynJmV1dY9T 5u4pJ6dRpUzQRKX/yudxR8nEwxVGaoyWiuuSE6NcHq+yWEO95z8f9TNPcNwBm4CT+8pe c2ysryVHk0Y4W1KJQM0pv19yAO1YflbwngFax563OZYyI5JP81S38tCnkojy75OeY0xj lzZyiF3whCYOgJiYVTdkpIb9rD5GkZqnCdTwTFUB49SmAglT4hh3z85lA6Kq963RyZcf +YZE4bxBa1NV4CWE709uGw6l+VjV4nzr1SEg1mYyxocd2qCirio8JZsJJfMTHtEl+E+A LYbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=3yTOkL9t5bs0xrL7mN8cuE5iHffQ5HTUGsUpDdXU+As=; b=EcV5Yvb+EnW3nUz26DjSf0tOevFKNtfuUoAGjCCq55cZbBwL75EizxGAks3fADgc1r RuRQdOG79kwWzoqy6tl+htvaT6rhbO22LLLs7ZeLc52j4psfcVbmkOL+Q8njX8ZAA0xd 0ZD77l3mv6jS8GyRZweqsQvayfcP+XqroZCzhhw+/Fpa9K54yXn+2FmL0vhHVfVBBbO+ jng/Zz3uVWNhRQKNBNaysdqjXheNCTWl+uH/gKmzfIOZN+cydBjxv8yaDA2NE/OIqgK8 ioYFWAUJCGK/dDlay/Colc/2Xmc504ZFdsDJkZ/ZsHwqajfz9TFvFnQb2k4EyoyM0tvZ kuTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si16765538pgm.561.2019.06.02.22.17.31; Sun, 02 Jun 2019 22:17:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726707AbfFCFQ1 (ORCPT + 99 others); Mon, 3 Jun 2019 01:16:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52574 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbfFCFQ0 (ORCPT ); Mon, 3 Jun 2019 01:16:26 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A4F681340AD5A; Sun, 2 Jun 2019 22:16:25 -0700 (PDT) Date: Sun, 02 Jun 2019 22:15:50 -0700 (PDT) Message-Id: <20190602.221550.1371676212285136500.davem@davemloft.net> To: blackgod016574@gmail.com Cc: rppt@linux.vnet.ibm.com, mhocko@suse.com, akpm@linux-foundation.org, sfr@canb.auug.org.au, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mdesc: fix a missing-check bug in get_vdev_port_node_info() From: David Miller In-Reply-To: <20190531012418.GA4473@zhanggen-UX430UQ> References: <20190531012418.GA4473@zhanggen-UX430UQ> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Jun 2019 22:16:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gen Zhang Date: Fri, 31 May 2019 09:24:18 +0800 > In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated > by kstrdup_const(), and it returns NULL when fails. So > 'node_info->vdev_port.name' should be checked. > > Signed-off-by: Gen Zhang Applied, thanks.