Date: Thu, 17 Nov 2005 15:52:30 -0800 (PST)
Message-Id: <20051117.155230.25121238.davem@davemloft.net>
To: hugh@veritas.com
Cc: akpm@osdl.org, nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] unpaged: COW on VM_UNPAGED
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <Pine.LNX.4.61.0511171936440.4563@goblin.wat.veritas.com>
References: <Pine.LNX.4.61.0511171925290.4563@goblin.wat.veritas.com>
	<Pine.LNX.4.61.0511171936440.4563@goblin.wat.veritas.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 27

From: Hugh Dickins <hugh@veritas.com>
Date: Thu, 17 Nov 2005 19:37:23 +0000 (GMT)

> Remove the BUG_ON(vma->vm_flags & VM_UNPAGED) from do_wp_page, and let
> it do Copy-On-Write without touching the VM_UNPAGED's page counts - but
> this is incomplete, because the anonymous page it inserts will itself
> need to be handled, here and in other functions - next patch.
> 
> We still don't copy the page if the pfn is invalid, because the
> copy_user_highpage interface does not allow it.  But that's not been
> a problem in the past: can be added in later if the need arises.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

Do we even need this?  It is a very serious question...

The cases I've seen, and am aware of, I documented in a previous
mail and those involve MAP_PRIVATE maps of /dev/mem or other
similar fixed page mapping devices.

Which case truly needs COW faults on VM_RESERVED memory which
isn't an application bug of some sort?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/