Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] scripts/decode_stacktrace: Accept dash/underscore in
 modules
To:     Evan Green <evgreen@chromium.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Douglas Anderson <dianders@chromium.org>,
        linux-kernel@vger.kernel.org,
        Nicolas Boichat <drinkcat@chromium.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Manuel Traut <manut@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20190531205926.42474-1-evgreen@chromium.org>
From:   Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Message-ID: <f9d0688c-246b-70b9-cdac-062dd9d329b2@yandex-team.ru>
Date:   Mon, 3 Jun 2019 10:51:04 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190531205926.42474-1-evgreen@chromium.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31.05.2019 23:59, Evan Green wrote:
> The manpage for modprobe mentions that dashes and underscores are
> treated interchangeably in module names. The stack trace dumps seem
> to print module names with underscores. Use bash to replace _ with
> the pattern [-_] so that file names with dashes or underscores can be
> found.
> 
> For example, this line:
> [   27.919759]  hda_widget_sysfs_init+0x2b8/0x3a5 [snd_hda_core]
> 
> should find a module named snd-hda-core.ko.
> 
> Signed-off-by: Evan Green <evgreen@chromium.org>

Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

> ---
> 
> Note: This should apply atop linux-next.
> 
> Thanks to Doug for showing me the bash string substitution magic.
> 
> ---
>   scripts/decode_stacktrace.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index fa704f17275e..13e5fbafdf2f 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
>   		local objfile=${modcache[$module]}
>   	else
>   		[[ $modpath == "" ]] && return
> -		local objfile=$(find "$modpath" -name "$module.ko*" -print -quit)
> +		local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
>   		[[ $objfile == "" ]] && return
>   		modcache[$module]=$objfile
>   	fi
>