Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750739AbVKRBvw (ORCPT ); Thu, 17 Nov 2005 20:51:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750750AbVKRBvw (ORCPT ); Thu, 17 Nov 2005 20:51:52 -0500 Received: from mail.kroah.org ([69.55.234.183]:58338 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S1750739AbVKRBvv (ORCPT ); Thu, 17 Nov 2005 20:51:51 -0500 Date: Thu, 17 Nov 2005 17:09:32 -0800 From: Greg KH To: Alan Stern Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [linux-usb-devel] [PATCH 02/02] USB: add dynamic id functionality to USB core Message-ID: <20051118010932.GA11514@suse.de> References: <20051117162533.GB26824@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 26 On Thu, Nov 17, 2005 at 12:19:43PM -0500, Alan Stern wrote: > On Thu, 17 Nov 2005, Greg KH wrote: > > > > > + fields = sscanf(buf, "%x %x", &idVendor, &idProduct); > > > > + if (fields < 0) > > > > + return -EINVAL; > > > > > > Don't you want to test (fields < 2)? > > > > No, it's ok to just specify the vendor, if you want a product of 0 :) > > > > PCI does it this way too. > > Well, in that case shouldn't you test (fields < 1)? Yeah, good point. I've also changed it to be < 2, as it doesn't really make sense to have a product number of 0. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/