Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3908958ybi; Mon, 3 Jun 2019 02:19:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqyPtXSjalqtiqe0ktV263Mqx6sKjzqVWHoyBLxQ0ocagIEwzVBep0Im+rB5i0w4kdgueKOb X-Received: by 2002:a17:902:2a28:: with SMTP id i37mr27792828plb.52.1559553594902; Mon, 03 Jun 2019 02:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559553594; cv=none; d=google.com; s=arc-20160816; b=VDTY286dHzrPFfrPHncAoNE9pWoRkB6afhzk78C/sToq2S/fwiF+QT5kjnDbNU5LWE 2hp1ltXnE9NdR5SYktx0euHg0L07vtE6Nj1ypWJivA9MUlJmDe1aobTnFPPzKgo3IvNn 7kVJniSa0mONRQBiHIxb9v1huPvoityOkPC29hbbJWsTVqKBwprNpiUaYLIM63igf4h4 c/dzo0SKNSe5gTFivFm8N9ufeTt8QTSUtegMnZQ7USRKS4tIlwKM19i8sp2BkNcXm8IN Dq+hMkXerB19NdkC4mpzhsIy5P0g0rPFlXI3MmQ62IjEuIrcb93pIkdHQrfSVFkk/pda w94A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zfsWjUZ11Aoa3fP/ob5tZalSWSQPoyx5WBwMU4shFwU=; b=hMlo9riXKoSLiTI/Nw7GisGJbdTOYx3zQjE9dqkBcMG/SKFAEn+ggKqpj/l2kPZnSP WWdAcP2qdCKpGgrix61+JCEA6/+ICLy+X4YvvI8reG5t4jJNUqayhxgrPwtRrg4Wa+Pk 2C1Z1FqfDwjxoNckchY6P/XWIxnKgVbCyMnMrkGZCjGvUaxgt9ETMaq7SVS2CPXyQA6z zzI9nv8l8qQydYVGIx6+sbnbXSbWyu+x2j2CDi8SWFF4Oli38Wdrs3lU1AG4F6uT+qBV hTrahu54MqalqhRqCaKKlDFlEDaBy/LX2v+cOiGgZo7TWedwV9UKBT2KFg6LyltTp3bm HduQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZNHwroYc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14si18740482pfh.232.2019.06.03.02.19.39; Mon, 03 Jun 2019 02:19:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZNHwroYc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbfFCJLl (ORCPT + 99 others); Mon, 3 Jun 2019 05:11:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:56822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728440AbfFCJLj (ORCPT ); Mon, 3 Jun 2019 05:11:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A495827E7A; Mon, 3 Jun 2019 09:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559553098; bh=ZAwey9El/ODFZAWcujVsTBv2WCksD9veMZj0nHo1jek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZNHwroYcfIM8d3VdLDTDU0p3c5HlLN96RtkG9H1sht6L5nITb7IgB0VnVo+Mz7fYA yrcteVe/cB7vojXTCeV+bavQyw9YVkyPqTtXZ2raH2Vv/ZkaXGQVHtrcgGnL/SEgam nZnFrbBVeBnEJi3JiFIjxuTzJsdydSEvqH/xMB2E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Raju Rangoju , "David S. Miller" Subject: [PATCH 5.0 02/36] cxgb4: offload VLAN flows regardless of VLAN ethtype Date: Mon, 3 Jun 2019 11:08:50 +0200 Message-Id: <20190603090521.133068585@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190603090520.998342694@linuxfoundation.org> References: <20190603090520.998342694@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raju Rangoju [ Upstream commit b5730061d1056abf317caea823b94d6e12b5b4f6 ] VLAN flows never get offloaded unless ivlan_vld is set in filter spec. It's not compulsory for vlan_ethtype to be set. So, always enable ivlan_vld bit for offloading VLAN flows regardless of vlan_ethtype is set or not. Fixes: ad9af3e09c (cxgb4: add tc flower match support for vlan) Signed-off-by: Raju Rangoju Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c @@ -228,6 +228,9 @@ static void cxgb4_process_flow_match(str fs->val.ivlan = vlan_tci; fs->mask.ivlan = vlan_tci_mask; + fs->val.ivlan_vld = 1; + fs->mask.ivlan_vld = 1; + /* Chelsio adapters use ivlan_vld bit to match vlan packets * as 802.1Q. Also, when vlan tag is present in packets, * ethtype match is used then to match on ethtype of inner @@ -238,8 +241,6 @@ static void cxgb4_process_flow_match(str * ethtype value with ethtype of inner header. */ if (fs->val.ethtype == ETH_P_8021Q) { - fs->val.ivlan_vld = 1; - fs->mask.ivlan_vld = 1; fs->val.ethtype = 0; fs->mask.ethtype = 0; }