Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3999303ybi; Mon, 3 Jun 2019 04:05:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTFxH9vDKJqU8Hzb3ZRSn7GCJoMF0e4+I48KFie8lX+uJegOq/fRuSJFGNhTfLFoVbHpKH X-Received: by 2002:aa7:8a87:: with SMTP id a7mr30221205pfc.53.1559559941584; Mon, 03 Jun 2019 04:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559559941; cv=none; d=google.com; s=arc-20160816; b=gXdSqaeqJK4MF5eluYCUkmeL3NYtaY4DxET7K2LSJzlb5qE84oevLPzgTqsUxvWZGu Y0nEMaXL7Jdy2KMtAQ8w6b+1NWVpdFBGXpn8zi3nw8TaK4rIGlIwgFDeSUAbtBwgGZ3J dFka8i0Nl/gYtewtfVuml74/Zu4f7CMjXUZCrW6TtJ9H6sdMXYJQMFqfnspS5hukN7xT 87QJy/77CRpAhw1WZ9KQUkUcpQWxBh9gmYCSCAcT+iLQZolYrcMn8WSbX9zP/pQ+GbbG DBU+vYcbFB+nDbo0ygjOTwEHhHPndXaef4XRSQnb5g/XuUV8DOTjwlI5x9yTRpPDePkY Et1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=GsRZSm4Q5uwPKH6PCtg57Kl8pOILzAAs4yb0cXdQ9S4=; b=vtCQYErZYt5EOqWWhkdER/PODeuMjnkwQUWOsGP9O7VJrUfEYZA4EwK2XcDw6zNfV8 H0evZqAxXB3HNbYCm/JJWQdL+yQtptlG0T9+S/vFXFDgsDfsGKVxHW1fWI0X5vljyKvf tA891WotvUyHX1T7QF4Npb9AM2QsXZpZ+iA5woXHY156IsRWd27WZhhUaJELhwtPjpnO v7CEw2sAdPPPra+GJ1l2C03wqG1EolyhvWABp6IpqyR+QjB/d/2qaEA6pKVYVgV4Kp6e gl/fLJpVeB0avUOvsRKdv/ynmazBhA82fIsAQXSK+0On92fydZa3khUHyI0toZd/hcP6 K6fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=SVJsieYM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si17116858pgv.195.2019.06.03.04.05.22; Mon, 03 Jun 2019 04:05:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=SVJsieYM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727714AbfFCIpV (ORCPT + 99 others); Mon, 3 Jun 2019 04:45:21 -0400 Received: from mail-eopbgr60063.outbound.protection.outlook.com ([40.107.6.63]:47052 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726653AbfFCIpV (ORCPT ); Mon, 3 Jun 2019 04:45:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GsRZSm4Q5uwPKH6PCtg57Kl8pOILzAAs4yb0cXdQ9S4=; b=SVJsieYMD3RVfQG3XIh8/o8j3wdB7AJ0XWb/Z0KbqLFJPZZKF/GYRciIAtdlwKs1Nn3Bw0UVgRVccwyJoIbYdkvjeHrln82D9RQCEJsAqxHnj+Ec0G0pgdWP/rUo1BqJoiZZS/CvSeWFAn/iDRE1QaxNot8CxR6x3bGhKh6prkk= Received: from VI1PR04MB5055.eurprd04.prod.outlook.com (20.177.50.140) by VI1PR04MB5405.eurprd04.prod.outlook.com (20.178.121.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.21; Mon, 3 Jun 2019 08:45:16 +0000 Received: from VI1PR04MB5055.eurprd04.prod.outlook.com ([fe80::9577:379c:2078:19a1]) by VI1PR04MB5055.eurprd04.prod.outlook.com ([fe80::9577:379c:2078:19a1%7]) with mapi id 15.20.1943.018; Mon, 3 Jun 2019 08:45:16 +0000 From: Leonard Crestez To: Anson Huang , "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "maxime.ripard@bootlin.com" , "olof@lixom.net" , "horms+renesas@verge.net.au" , "jagan@amarulasolutions.com" , "bjorn.andersson@linaro.org" , "dinguyen@kernel.org" , "enric.balletbo@collabora.com" , Aisheng Dong , Jacky Bai , Abel Vesa , "l.stach@pengutronix.de" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" CC: dl-linux-imx Subject: Re: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver Thread-Topic: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver Thread-Index: AQHVGaxdHZzNGD6lS0CX40Io7wcnXg== Date: Mon, 3 Jun 2019 08:45:16 +0000 Message-ID: References: <20190603013503.40626-1-Anson.Huang@nxp.com> <20190603013503.40626-2-Anson.Huang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; x-originating-ip: [192.88.166.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20ad664a-a97c-4f7d-92bd-08d6e7ffcd1f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR04MB5405; x-ms-traffictypediagnostic: VI1PR04MB5405: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:85; x-forefront-prvs: 0057EE387C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(396003)(39860400002)(366004)(136003)(199004)(189003)(73956011)(66946007)(5660300002)(8936002)(256004)(33656002)(53936002)(110136005)(81166006)(66476007)(64756008)(55016002)(66446008)(68736007)(4326008)(81156014)(66556008)(9686003)(229853002)(6246003)(316002)(186003)(76116006)(91956017)(6436002)(7416002)(26005)(8676002)(52536014)(99286004)(7736002)(53546011)(86362001)(486006)(305945005)(44832011)(14454004)(71200400001)(71190400001)(6506007)(4744005)(7696005)(102836004)(478600001)(2906002)(76176011)(74316002)(25786009)(3846002)(6116002)(446003)(2201001)(476003)(2501003)(66066001)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5405;H:VI1PR04MB5055.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: b+cMDmjrLCiyDc+HtJ7JzACpOq1FoEPFi/g54Ze0MIGQlkBJcTYmhEyksME2cMiIujn+WrYBBroLp/PINgmv36VeS7BobFHKkKyQzkuUZOW7SUnKtcHf7adiJwWBgE3LJSR8IyhMeEIu3Dr6QmJBBwGerjf/nCQXbevFbn992mtIPDaVg7IUXA07lXZDNiWjaZOFkwjyIgWh1c0BBzgoEY35OWC8MUMTzHEixPPw4SqKlENVXAxiHozFghGyvPg7ODHBMKPggXWnkonrx7+5mmz2OkebyHE4/NbU1VZthuYiTiGbpnumN1j1Dn74vt31FsZuKuD8l3biTRKmcv2sEmJhkIpAihJubEaXhe7pjEZuGeSXRXyHBq6X0mgQB7HZ7iIhjc+slQppb8iOkMWafm8zUSTra7xHNt/VI9hENdc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20ad664a-a97c-4f7d-92bd-08d6e7ffcd1f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2019 08:45:16.2239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: leonard.crestez@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5405 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/3/2019 4:33 AM, Anson.Huang@nxp.com wrote:=0A= > From: Anson Huang =0A= > =0A= > This patch adds i.MX8MN clock driver support. =0A= =0A= > +#include "clk.h"=0A= > +=0A= > +#define PLL_1416X_RATE(_rate, _m, _p, _s) \=0A= > + { \=0A= > + .rate =3D (_rate), \=0A= > + .mdiv =3D (_m), \=0A= > + .pdiv =3D (_p), \=0A= > + .sdiv =3D (_s), \=0A= > + }=0A= > +=0A= > +#define PLL_1443X_RATE(_rate, _m, _p, _s, _k) \=0A= > + { \=0A= > + .rate =3D (_rate), \=0A= > + .mdiv =3D (_m), \=0A= > + .pdiv =3D (_p), \=0A= > + .sdiv =3D (_s), \=0A= > + .kdiv =3D (_k), \=0A= > + }=0A= =0A= These macros are shared with clk-imx8mm (and perhaps some future chips) =0A= so they should be moved to driver/clk/imx/clk.h=0A=