Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4075975ybi; Mon, 3 Jun 2019 05:24:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJdyfLhT520t9Sr1UBAPkkButkImIAnyY95tw1qoLxBPzsgvgDRr14fTOdwvdZHb9fcpaZ X-Received: by 2002:a17:902:bd46:: with SMTP id b6mr29323999plx.173.1559564662517; Mon, 03 Jun 2019 05:24:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559564662; cv=none; d=google.com; s=arc-20160816; b=ECNS2Kt2p/fpCCIosM+hmqQ3LhXUlCP5xgTwdzHotXQ+p/3QkxrSXeho0WdtRLvOev lQYZKHzYGTBtAK/tdGmpAx62aLPlHp/qLWJcLsUCdlKOoJdxV1hgMqATd5rFgEBOZTRX 3hNCrgHVJVmuXqhJOwbywU4h45bFOtj1Cx3Y6fvMMptkNSHSDLJLjeWa44YaTktyhOc/ xWz/1DwNjtp5100tVj+aQgml1MbKW2f35vk38yobHCwuhUyFa/AkulT0vo0QXD2hM+yU L8A3aoyerFOshzmngn5qZf2sWOE+6sv633ASiPlwL/eupIxgNnFHT5tJbTioVRycwfrw AoOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=sXMTCyDkjPlOrJCa2lXvJZdPqWB+jA4aoGwAAeWFyDo=; b=vQReRjPxswxyUntdZmLEJaWY2Xwk1kMYOzCF/mR8nPhmEu98XC1MwOQkQxxaVqyftJ ldxzD60bf9YMH47NtJ8LcM2Na2SZG96beriE+FOxRSAj7x+z499dd0HBh/IZ5dfkahQb KYpcwKmGafWxT40T/tQ4nCB7ExFCV9LSNHDVFjI0fWAjNxceZ/TCXp46wOVveP8pOe39 uZUrXCi+Wpz13yXRwf0zKg2d+PzcstfRFVtmerJeDQG7IxkP1dziCN+h9STTKLBvDKYZ XP5qWnCdxaqRhc1sVQz7eYIVnmdK6ph4t/2HYHAbItBGZqQtHRe5U4NF1iDBy9kEz6x/ CGAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 35si20354759plb.62.2019.06.03.05.24.06; Mon, 03 Jun 2019 05:24:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727130AbfFCMLJ (ORCPT + 99 others); Mon, 3 Jun 2019 08:11:09 -0400 Received: from mga17.intel.com ([192.55.52.151]:23637 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbfFCMLI (ORCPT ); Mon, 3 Jun 2019 08:11:08 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 05:11:08 -0700 X-ExtLoop1: 1 Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by orsmga005.jf.intel.com with ESMTP; 03 Jun 2019 05:11:04 -0700 Subject: Re: [PATCH 1/9] mmc: sdhci-sprd: Check the enable clock's return value correctly To: Baolin Wang , ulf.hansson@linaro.org, zhang.lyra@gmail.com, orsonzhai@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de, olof@lixom.net Cc: vincent.guittot@linaro.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <7e4d922ba5aff5241b0186e9480a98b14693b28d.1558346019.git.baolin.wang@linaro.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 3 Jun 2019 15:09:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <7e4d922ba5aff5241b0186e9480a98b14693b28d.1558346019.git.baolin.wang@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/19 1:11 PM, Baolin Wang wrote: > Missed to check the enable clock's return value, fix it. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > index 9a822e2..e741491 100644 > --- a/drivers/mmc/host/sdhci-sprd.c > +++ b/drivers/mmc/host/sdhci-sprd.c > @@ -368,7 +368,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev) > if (ret) > goto pltfm_free; > > - clk_prepare_enable(sprd_host->clk_enable); > + ret = clk_prepare_enable(sprd_host->clk_enable); > if (ret) > goto clk_disable; > >