Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbVKRDhH (ORCPT ); Thu, 17 Nov 2005 22:37:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932399AbVKRDhG (ORCPT ); Thu, 17 Nov 2005 22:37:06 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:63238 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932325AbVKRDhE (ORCPT ); Thu, 17 Nov 2005 22:37:04 -0500 Date: Fri, 18 Nov 2005 04:37:02 +0100 From: Adrian Bunk To: Dave Jones , Andrew Morton , linux-kernel@vger.kernel.org Cc: rusty@rustcorp.com.au, dwmw2@infradead.org, linux-mtd@lists.infradead.org Subject: [2.6 patch] build kernel/intermodule.c only when required Message-ID: <20051118033702.GY11494@stusta.de> References: <20051118014055.GK11494@stusta.de> <20051117175015.6aa99fcf.akpm@osdl.org> <20051118020640.GM11494@stusta.de> <20051117182047.5fe1a5eb.akpm@osdl.org> <20051118024433.GN11494@stusta.de> <20051117185529.31d33192.akpm@osdl.org> <20051118031751.GA2773@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051118031751.GA2773@redhat.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2872 Lines: 90 On Thu, Nov 17, 2005 at 10:17:51PM -0500, Dave Jones wrote: > On Thu, Nov 17, 2005 at 06:55:29PM -0800, Andrew Morton wrote: > > > > IMHO the warnings are the best solution for getting a vast amount fixed, > > > and then it's time to think about the rest. > > > > But the warnings don't *work*. I'm *still* staring at stupid pm_register > > and intermodule_foo warnings. How long has that been? > > Too long. I think the mtd stuff won't ever get fixed until after that > function gets removed. Let's limit the inclusion of kernel/intermodule.c to the users of these drivers. > Dave cu Adrian <-- snip --> Let's build kernel/intermodule.c only when required. Signed-off-by: Adrian Bunk --- drivers/mtd/chips/Kconfig | 1 + drivers/mtd/devices/Kconfig | 1 + init/Kconfig | 3 +++ kernel/Makefile | 3 ++- 4 files changed, 7 insertions(+), 1 deletion(-) --- linux-2.6.15-rc1-mm1-full/init/Kconfig.old 2005-11-18 03:22:53.000000000 +0100 +++ linux-2.6.15-rc1-mm1-full/init/Kconfig 2005-11-18 03:23:29.000000000 +0100 @@ -456,6 +456,9 @@ default !SLAB bool +config OBSOLETE_INTERMODULE + tristate + menu "Loadable module support" config MODULES --- linux-2.6.15-rc1-mm1-full/kernel/Makefile.old 2005-11-18 03:21:55.000000000 +0100 +++ linux-2.6.15-rc1-mm1-full/kernel/Makefile 2005-11-18 03:22:35.000000000 +0100 @@ -6,10 +6,11 @@ exit.o itimer.o time.o softirq.o resource.o \ sysctl.o capability.o ptrace.o timer.o user.o \ signal.o sys.o kmod.o workqueue.o pid.o \ - rcupdate.o intermodule.o extable.o params.o posix-timers.o \ + rcupdate.o extable.o params.o posix-timers.o \ kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o \ ktimers.o +obj-$(CONFIG_OBSOLETE_INTERMODULE) += intermodule.o obj-$(CONFIG_FUTEX) += futex.o obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o obj-$(CONFIG_SMP) += cpu.o spinlock.o --- linux-2.6.15-rc1-mm1-full/drivers/mtd/chips/Kconfig.old 2005-11-18 03:23:52.000000000 +0100 +++ linux-2.6.15-rc1-mm1-full/drivers/mtd/chips/Kconfig 2005-11-18 03:28:09.000000000 +0100 @@ -31,6 +31,7 @@ config MTD_GEN_PROBE tristate + select OBSOLETE_INTERMODULE config MTD_CFI_ADV_OPTIONS bool "Flash chip driver advanced configuration options" --- linux-2.6.15-rc1-mm1-full/drivers/mtd/devices/Kconfig.old 2005-11-18 03:25:17.000000000 +0100 +++ linux-2.6.15-rc1-mm1-full/drivers/mtd/devices/Kconfig 2005-11-18 03:27:46.000000000 +0100 @@ -202,6 +202,7 @@ config MTD_DOCPROBE tristate select MTD_DOCECC + select OBSOLETE_INTERMODULE config MTD_DOCECC tristate - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/