Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4252865ybi; Mon, 3 Jun 2019 07:59:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhuOM6w05p5fP+caEevs/OezBKaYi0e/c0EPeEvrFa1djPgIjQhwW157TktZMkfrWIJ/SC X-Received: by 2002:a17:90a:5d15:: with SMTP id s21mr30047849pji.125.1559573986567; Mon, 03 Jun 2019 07:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559573986; cv=none; d=google.com; s=arc-20160816; b=x/uLvW0VpbPed3OwnukxCKmLKR5AMghF37JoPavBvifZ9ObZNmxykObQNW85hlPLem gVe+eSu1p5ufLIzrBai5J3dIlh1EsUsjhKQIxTTb1lhC+LwKtGFmpNBKyzWHHkEIhPNf atGGazxYbRo/lOihCpl9939T5TyMmB50AXrSjYe5Iq33tn6Zft22eRkYPZ1NorfpGBSG wZxUK0ZJmEI7LZAfdqFj9sK9HlnM/pbN6BrdBp1P6LuNcHbx42lz8ZKY02MIDrjsOdYG 6JVzpZEgzap+158CLwMjHb7H1EnB0sCzpwsyegjxi1z2TLsDENZKbRt7jvvrjAS0i978 rkew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nMmMLyY2wEe5mWxFYfJb9I4vcVoHvhNf68CYZFM42uk=; b=G6j8IBT77XOO66f2ARIqkrS7ynhVvO+ExfZ2X0vA4UMdyQjQhconEeItsxj3e271dh DjQwQUjvveKlhZGKn7rTtkmKcxwAqP8fXZqGnjfUWxIgf+heKJRzBv0i4rsNSPwHW2WI bkRZ6JenmBIDNEOJqERievMiXZodIP4Z1oNveNB32ylbF9cZpCdiPIoSgiYS7jm1HUOc bydvedJsa5lAVK/rHiNdyxCySl5PEUauCE4BiSZxtnbnGaVyZwM8CuRpG9pVvW54ZCeA VePd/VlrRZ9925JXd6NTehIVKmr1Tberqi+butssfJeJJfO/rN1B1aQxbsxkhWer/6kp eqtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=CPjDhy34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si19178490pff.117.2019.06.03.07.59.30; Mon, 03 Jun 2019 07:59:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=CPjDhy34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729228AbfFCO5t (ORCPT + 99 others); Mon, 3 Jun 2019 10:57:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50710 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728882AbfFCO5t (ORCPT ); Mon, 3 Jun 2019 10:57:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nMmMLyY2wEe5mWxFYfJb9I4vcVoHvhNf68CYZFM42uk=; b=CPjDhy34HoELRaZtg04tonm0u6 EY75gQhD1ZpN35ePf3FdkH0uzZruwLmIZRDl/rBTKB2H900ruQFUEI3/0HJCG0Ghy1AOgOVP0iA2c w5S9Wn5g0fgFgI3l9+GellAYunm6QvJ433kfRXYyQ7p/Aq7mF9lsr0p1c5Kdsi+O6ps0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXoP9-0005uz-EO; Mon, 03 Jun 2019 16:57:43 +0200 Date: Mon, 3 Jun 2019 16:57:43 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: Vivien Didelot , Florian Fainelli , "David S. Miller" , Rasmus Villemoes , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3 01/10] net: dsa: mv88e6xxx: add mv88e6250_g1_ieee_pri_map Message-ID: <20190603145743.GD19627@lunn.ch> References: <20190603144112.27713-1-rasmus.villemoes@prevas.dk> <20190603144112.27713-2-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603144112.27713-2-rasmus.villemoes@prevas.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 02:42:12PM +0000, Rasmus Villemoes wrote: > diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h > index bb92a130cbef..2bcbe7c8b279 100644 > --- a/drivers/net/dsa/mv88e6xxx/global1.h > +++ b/drivers/net/dsa/mv88e6xxx/global1.h > @@ -279,6 +279,8 @@ int mv88e6390_g1_mgmt_rsvd2cpu(struct mv88e6xxx_chip *chip); > int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip); > int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); > > +int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); > + Hi Rasmus We are not 100% consistent, but we try to put all variants of a method together, and then put a blank line afterwards. So could you make this: int mv88e6085_g1_ip_pri_map(struct mv88e6xxx_chip *chip); int mv88e6085_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); int mv88e6250_g1_ieee_pri_map(struct mv88e6xxx_chip *chip); int mv88e6185_g1_set_cascade_port(struct mv88e6xxx_chip *chip, int port); Reviewed-by: Andrew Lunn Andrew