Date: Fri, 18 Nov 2005 08:13:54 +0000 (GMT)
From: Hugh Dickins <hugh@veritas.com>
To: "David S. Miller" <davem@davemloft.net>
cc: nickpiggin@yahoo.com.au, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] unpaged: COW on VM_UNPAGED
In-Reply-To: <20051118.000802.81426185.davem@davemloft.net>
Message-ID: <Pine.LNX.4.61.0511180813110.5788@goblin.wat.veritas.com>
References: <437D6AD0.5080909@yahoo.com.au> <20051117.224516.118147408.davem@davemloft.net>
 <Pine.LNX.4.61.0511180730530.5435@goblin.wat.veritas.com>
 <20051118.000802.81426185.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 21

On Fri, 18 Nov 2005, David S. Miller wrote:
> From: Hugh Dickins <hugh@veritas.com>
> Date: Fri, 18 Nov 2005 08:02:02 +0000 (GMT)
> 
> > That code is necessary to reproduce the existing behaviour, which has
> > always done COW on PageReserved mappings without complaint - if the
> > vm_page_prot didn't already let you slip through without a WP fault.
> 
> And there is evidence today that this is really needed, at least
> by vbetool.
> 
> Ok, we need COW on VM_UNPAGED. :)

Are you so sure of that, that we should even skip adding a warning?

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/