Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4443777ybi; Mon, 3 Jun 2019 10:57:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqz5+YlAeNzhv1KdhSfpNLzLh9ZaVsWkYQiO5AeSLpQehNfnMs2ZVkbgAxydF1MLfhvi3zJB X-Received: by 2002:a17:902:2862:: with SMTP id e89mr31917558plb.258.1559584656063; Mon, 03 Jun 2019 10:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559584656; cv=none; d=google.com; s=arc-20160816; b=pFMIjhcstZ04SsDojvjiPyBgoxQz/KcoGt6Ja4i7VlUowlcwk0vYDWafd+NoYU7Vh6 s3cai7U2gBELVVcF1QsnjaIcyhEmQg4Q7lBeqDobD3NQhIXBISoxRhvmFdMdxQb6OpUB QFKMAwyS0cP6EWnU8rcQaMaTLPx+DatumG3vFhlartcYNivSB4xVNqNmsZxSTooiOIsN skxaAqStnxZhN77y3GCpbRB9TOERCQFDOh41UKSgqAlJg8LBCbQ8rkGuJ5BUGwT/JPAv lpZ70juQFBnof+jqcQ7dX3c895E2gDUtMb+GPGFdneD98wqsaFiA0BruQIgDguZ83KlJ OtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=f1Dtl9xXT8tEGwrUxBzQBfGddt3tp9MI+UPqkpN1WN0=; b=eCy3ocKU22GJxdd5GNkhQrIGHvtsABt9EwL6gwDuqNheMRPDEKszqgoFVlTEPSyTNe nB9+zHstwVQ3FglhkVKfruReMkUR4vCzcf/QVl/y8/dpCBpmtjbr9zkU8iKDd1CEUCVd p1eAD8VPDn7ypvzuZWhS8TM/77ZaIhqANEpw2oT0nDW5lxgZQVD6/nnjh3vBwBY5ecdx wVjKbwDSqTCbrnovMOPDgUtGllLHhxasMKP3jeTC8LZ3U27F/y7a1jCAZqvSt8w7AqpW NNz9z7ge7XBYYxOVhf5xga4qUMpH2Bw75jndYiGp14L8RwgmqDa7LHKsMDW5hUlj1O4Y yw3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mqTz1839; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si18843008pjd.48.2019.06.03.10.57.20; Mon, 03 Jun 2019 10:57:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mqTz1839; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728948AbfFCRrj (ORCPT + 99 others); Mon, 3 Jun 2019 13:47:39 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34445 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfFCRrj (ORCPT ); Mon, 3 Jun 2019 13:47:39 -0400 Received: by mail-lf1-f66.google.com with SMTP id y198so3797795lfa.1 for ; Mon, 03 Jun 2019 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f1Dtl9xXT8tEGwrUxBzQBfGddt3tp9MI+UPqkpN1WN0=; b=mqTz1839SvTGVA6JMBG6+XjE0xYwF2fSddZ7+seYCgdrXgukg0+NU1E4tXpmGF15Im UZJXC+yUDioaBsN6la1dNtjTzmPzvL4teQe+GSwWL7g0C0GQ8xS+7Y5L2BBcCfXp+86x wmMcAuVi4hbPPf8Pu4a/f2A02J0NXA367FrEGeAtR7D+OzvyqwIKbnX6pmohPchdxcab om1NVhjh5ihdIMLobhgkrDeIrhVafIUwILMNvwzW9QzXJf7xfvMfpFZqOPjCRzZdWpdS xCDuNsMcjH7LJDGLtHTp/dy+CwlmAJLQAjPt9FsfMow6RPEaUZ3hCIdNIW31jvDpVBA0 Et6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f1Dtl9xXT8tEGwrUxBzQBfGddt3tp9MI+UPqkpN1WN0=; b=DDfIEuMVBS7ypq6Rl8VdBzC7GPDDJ/b7fyYid/ejXPVtw1pqAHtj+67BqXyt7HskY6 6tKksyqSMB1bVqqS0ZW8Ng8Wz32C2IAwoKAJ9KURRptKsmOAVgysx5gOI7c5gom3FzgT PW5QizjTA+sQJEm9+Y3HlhOQrdqZLMSoqRLQfTgTwIhS2nXYEU6FlcfqW/N7RIUDPpOQ 8dhVtv6IVJu27+RUjwSjeQhMz0JoeqfeDzuKvpuvgcbAeEvFAxpqGfq1WubRwW+E+PTq sr/zQsZ3EwQkgXKp3s4f1t17XOd51dWXv5rSjk4B1oz+xP2b8SRD0N52xGHuLNy41Co3 EDrg== X-Gm-Message-State: APjAAAXW29R+051qHkDQV054dmtBkFSUymx22nnTgNdCpjitqe+C5tH7 b42+i3X5qvtwhupKNNftGOY= X-Received: by 2002:ac2:599b:: with SMTP id w27mr15110769lfn.184.1559584057528; Mon, 03 Jun 2019 10:47:37 -0700 (PDT) Received: from localhost.localdomain ([188.150.253.81]) by smtp.gmail.com with ESMTPSA id n7sm2803532lfi.68.2019.06.03.10.47.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 10:47:36 -0700 (PDT) From: codekipper@gmail.com To: maxime.ripard@free-electrons.com, wens@csie.org, linux-sunxi@googlegroups.com Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, be17068@iperbole.bo.it, Marcus Cooper Subject: [PATCH v4 0/9]ASoC: sun4i-i2s: Updates to the driver Date: Mon, 3 Jun 2019 19:47:26 +0200 Message-Id: <20190603174735.21002-1-codekipper@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcus Cooper Hi All, here is a patch series to add some improvements to the sun4i-i2s driver found whilst getting slave clocking and hdmi audio working on the newer SoCs. As the LibreELEC project is progressing extremely well then there has been some activity getting surround sound working and this is included. The functionality included with the new patch set has been extended to cover more sample resolutions, multi-lane data output for HDMI audio and some bug fixes that have been discovered along the way. I can see more usage of the tdm property since I last attempted to push these patches and the examples currently in mainline sort of the opposite to what I'm trying to achieve. When we first started looking at the i2s driver, the codecs that we were using allowed for the frame width to be determined based on the sampling resolution but in most use cases it seems that a fixed width is required(my highest priority should be to get HDMI audio support in). We're using the tdm property to override the old way to calculate the frame width. What I've seen in what has already been mainlined is that the i2s driver has a frame width that is fixed to 32 bits and this can be overridden using the tdm property. I still need to investigate the FIFO syncing issues which i've not had a chance to change or address the concerns that broonie and wens brought up. This change has been moved to the top of the patch stack. BR, CK --- v4 changes compared to v3 are: - Moved patches around so that the more controversial of patches are at the top of the stack. - Added more details to commit messages. - Fixed 20bit audio PCM format to use 4 bytes. - Reduced number of flags used to indicate a new SoC. v3 changes compared to v2 are: - added back slave mode changes - added back the use of tdm properties - changes to regmap and caching - removed loopback functionality - fixes to the channel offset mask v2 changes compared to v1 are: - removed slave mode changes which didn't set mclk and bclk div. - removed use of tdm and now use a dedicated property. - fix commit message to better explain reason for sign extending - add divider calculations for newer SoCs. - add support for multi-lane i2s data output. - add support for 20, 24 and 32 bit samples. - add loopback property so blocks can be tested without a codec. Marcus Cooper (9): ASoC: sun4i-i2s: Fix sun8i tx channel offset mask ASoC: sun4i-i2s: Add offset to RX channel select ASoC: sun4i-i2s: Add regmap field to sign extend sample ASoC: sun4i-i2s: Reduce quirks for sun8i-h3 ASoC: sun4i-i2s: Add set_tdm_slot functionality ASoC: sun4i-i2s: Add multi-lane functionality ASoC: sun4i-i2s: Add multichannel functionality ASoc: sun4i-i2s: Add 20, 24 and 32 bit support ASoC: sun4i-i2s: Adjust regmap settings sound/soc/sunxi/sun4i-i2s.c | 242 ++++++++++++++++++++++++------------ 1 file changed, 164 insertions(+), 78 deletions(-) -- 2.21.0