Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4444821ybi; Mon, 3 Jun 2019 10:58:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxZPRotSCYfkjq4bWjX7rTQ6ZqFJDCWEbJdoRaTfnXidxqBR5kW/zrdh8lRCPlxRXcdCHD5 X-Received: by 2002:a63:4d5d:: with SMTP id n29mr30892880pgl.235.1559584728693; Mon, 03 Jun 2019 10:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559584728; cv=none; d=google.com; s=arc-20160816; b=BVnUo1RoHERmwrlnB2viPdessa3C4OEQGRE25RPk2xVfFH/dohg8zfLJGv7Ro0gTEG yCA24IGCs/a94DdZfzGEyGbIKVW7InM4Mr60spaXmaRzRnQIuUqHLM6JIe+pV9QIFl0O LqH+jpYeyApnzw1Tzy8VY8rKX9XeDLXEZsnlnNbWmqOzHzNlGMettNPrYdTL2cPRTK0w IhQ0qcEJekY+oADAE7LgkkKb5SxBRFiMaRCTmX+NF7IHW9jQaaLMo10H3VhUD0eRYhGT hX/iZ94vY0nwYuYARsIE3O1fOShQ4PBiHfdzwhz6MiHM+tJjrAyxuG8P/ofIgsbCR5NL KkSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=DGoxdD5EUIGT9bBxoW5B+18v9hq8tueDEjWNmvtG0II=; b=JoPvjBJFEo3KB/ehvKB1KESfxgpmPYv4LQGNhJfFidjdUuOU75ciFd8XmdZxYHF+pL 3vFWcbKn0kWIOO1AFD3ZYefiKhYS0zIrOq1Eh/8ovD6lCU3BqY2Qow1wwx6daH3FD3IV mPwwSnFIu1myW9c07LF37nPDJsNKWdfc5hwqfnN3ST6HKy+QcNiCEYBJLYR24kYAySdi /151VcnNBanD+/ksOhHV3oE31AlaHHOATZn7ngGNRwRyU5DV3DLE+Y+ocnAesRHWJa2J 6JKPuPkylQ44HwZ9YYBe4kav/9z65lB3bbRbp49lh9uyayyrxmZloYGpsaguignXTGJE Orwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ob1Luuhj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s11si3450359plp.208.2019.06.03.10.58.32; Mon, 03 Jun 2019 10:58:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ob1Luuhj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfFCRwb (ORCPT + 99 others); Mon, 3 Jun 2019 13:52:31 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39872 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbfFCRwb (ORCPT ); Mon, 3 Jun 2019 13:52:31 -0400 Received: by mail-pg1-f194.google.com with SMTP id 196so8711200pgc.6 for ; Mon, 03 Jun 2019 10:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=DGoxdD5EUIGT9bBxoW5B+18v9hq8tueDEjWNmvtG0II=; b=ob1LuuhjIlmwK3FDWvTNjdt5OAF8gJwg61MhWz2Mx/CWZtO36JkJe2KxBFhHrd/r/6 3NI+AAM2zh+2+hfcvuvBT5tbwG/HCWd5QAdIrLQRPFMud2AY0NKW9/CI14FNeeqlAOV4 ZjKEbiFClDENsZ8mC6zmO28eFhmmKZ3QL/NrNRjUD+MNT3IHEjHGPxvb+3wCdEWZN80m CLAdQdImWDFk8LKVgvMMKvHI+yaYfsnGwIKIcwQJYBAv1I500HiDj8iCSLvrnLmoy7A0 5Bhg4qqM+iTEHPXsJlZIL8Z+x28aJFhCq7QdGpQOC4uKbUeGZ7oFpdBt1QbkZCCptcSo e00w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=DGoxdD5EUIGT9bBxoW5B+18v9hq8tueDEjWNmvtG0II=; b=hrATWORgMyzYV7IR2NgqFpU3EzvuWly4Z1vUjs0ewcEpZChKOtUxOXvgPT3LJABSVE d3wYMQ5h/EFB9ulaaKGdczhEkQwldEio4MtHrf7fvBhe4Yqr5s/OIbbDTp1Xq1heLSd+ +n94DSkl22Asig1Lx7xFpQ3qs4z2y2E/U4kMimqsAg7haGupMdKFJopVwtXoNlD61Ft5 YqQkUuWLgJWNWuO+pk8wYJxvbZ18BcGkDS72gs+yS3Q77i/ce08KhMxVYnXP8PuCXIrQ Vl7lpy/WiF8aZ5iHTPzyo0HN/lc1mUhZd4kim3ShSCJyGurN4nA5EOlvDvDJeb4X1Yr7 R7jQ== X-Gm-Message-State: APjAAAXIzaerefMyDZUeB6LshBnV00o4ThQgSLLuV4/WWCaRUnu8dBtp EPV/0xiD5NWU1wRb0Ab/iTo= X-Received: by 2002:a63:d504:: with SMTP id c4mr21542620pgg.20.1559584350790; Mon, 03 Jun 2019 10:52:30 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.89.153]) by smtp.gmail.com with ESMTPSA id 127sm15459038pfc.159.2019.06.03.10.52.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 10:52:29 -0700 (PDT) Date: Mon, 3 Jun 2019 23:22:24 +0530 From: Hariprasad Kelam To: Greg Kroah-Hartman , Nathan Chancellor , Himadri Pandya , Arnd Bergmann , Hans de Goede , Hariprasad Kelam , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: hal: fix error "do not initialise globals to 0" Message-ID: <20190603175224.GA4969@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org this patch fixes below Errors reported by checkpatch ERROR: do not initialise globals to 0 +u8 g_fwdl_chksum_fail = 0; ERROR: do not initialise globals to 0 +u8 g_fwdl_wintint_rdy_fail = 0; Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index caa8e2f..21f2365 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -217,7 +217,7 @@ void _8051Reset8723(struct adapter *padapter) DBG_8192C("%s: Finish\n", __func__); } -u8 g_fwdl_chksum_fail = 0; +u8 g_fwdl_chksum_fail; static s32 polling_fwdl_chksum( struct adapter *adapter, u32 min_cnt, u32 timeout_ms @@ -262,7 +262,7 @@ static s32 polling_fwdl_chksum( return ret; } -u8 g_fwdl_wintint_rdy_fail = 0; +u8 g_fwdl_wintint_rdy_fail; static s32 _FWFreeToGo(struct adapter *adapter, u32 min_cnt, u32 timeout_ms) { -- 2.7.4