Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: Testing the recent RISC-V DT patchsets
From:   Troy Benjegerdes <troy.benjegerdes@sifive.com>
In-Reply-To: <8636krhubp.fsf@baylibre.com>
Date:   Mon, 3 Jun 2019 15:17:46 -0500
Cc:     Atish Patra <atish.patra@wdc.com>,
        Karsten Merker <merker@debian.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <038A3CC1-B970-4B1B-83C1-59992F609888@sifive.com>
References: <alpine.DEB.2.21.9999.1904221705170.18377@viisi.sifive.com>
 <alpine.DEB.2.21.9999.1905280105110.20842@viisi.sifive.com>
 <86o93mpqbx.fsf@baylibre.com>
 <20190528153542.jfkkwycyc3vu6hld@excalibur.cnev.de>
 <081611ea-a0d3-b0c9-3e08-8946513f2174@wdc.com> <86woi94lvs.fsf@baylibre.com>
 <BC002AAE-7EE6-404D-9204-D10263BEA5C9@sifive.com>
 <8636krhubp.fsf@baylibre.com>
To:     Loys Ollivier <lollivier@baylibre.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jun 3, 2019, at 4:49 AM, Loys Ollivier <lollivier@baylibre.com> =
wrote:
>=20
> On Wed 29 May 2019 at 12:25, Troy Benjegerdes =
<troy.benjegerdes@sifive.com> wrote:
>=20
>>> On May 29, 2019, at 5:04 AM, Loys Ollivier <lollivier@baylibre.com> =
wrote:
>>>=20
>>> On Wed 29 May 2019 at 00:50, Atish Patra <atish.patra@wdc.com> =
wrote:
>>>=20
>>>> On 5/28/19 8:36 AM, Karsten Merker wrote:
>>>>> On Tue, May 28, 2019 at 05:10:42PM +0200, Loys Ollivier wrote:
>>>>>> On Tue 28 May 2019 at 01:32, Paul Walmsley =
<paul.walmsley@sifive.com> wrote:
>>>>>>=20
>>>>>>> An update for those testing RISC-V patches: here's a new branch =
of
>>>>>>> riscv-pk/bbl that doesn't try to read or modify the DT data at =
all, which
>>>>>>> should be useful until U-Boot settles down.
>>>>> [...]
>>>>>>> Here is an Linux kernel branch with updated DT data that can be =
booted
>>>>>>> with the above bootloader:
>>>>>>>=20
>>>>>>>   =
https://github.com/sifive/riscv-linux/tree/dev/paulw/dts-v5.2-rc1-experime=
ntal
>>>>>>>=20
>>>>>>> A sample boot log follows, using a 'defconfig' build from that =
branch.
>>>>>>=20
>>>>>> Thanks Paul, I can confirm that it works.
>>>>>>=20
>>>>>> Something is still unclear to myself.
>>>>>> Using FSBL + riscv-pk/bbl the linux kernel + device tree boots.
>>>>>> Neither FSBL nor riscv-pk/bbl are modifying the DT.
>>>>>>=20
>>>>>> Using FSBL + OpenSBI + U-Boot the same kernel + device tree hangs =
on
>>>>>> running /init.
>>>>>>=20
>>>>>> Would you have any pointer on what riscv-pk does that =
OpenSBI/U-boot doesn't ?
>>>>>> Or maybe it is the other way around - OpenSBI/U-boot does =
something that
>>>>>> extra that should not happen.
>>>>>=20
>>>>> Hello,
>>>>>=20
>>>>> I don't know which version of OpenSBI you are using, but there is
>>>>> a problem with the combination of kernel 5.2-rc1 and OpenSBI
>>>>> versions before commit
>>>>>=20
>>>>>  =
https://github.com/riscv/opensbi/commit/4e2cd478208531c47343290f15b577d40c=
82649c
>>>>>=20
>>>>> that can result in a hang on executing init, so in case you
>>>>> should be using an older OpenSBI build that might be the source
>>>>> of the problem that you are experiencing.
>>>>>=20
>>>>> Regards,
>>>>> Karsten
>>>>>=20
>>>>=20
>>>> I verified the updated DT with upstream kernel for the boot flow =
OpenSBI=20
>>>> + U-Boot + Linux or OpenSBI + Linux.
>>>>=20
>>>> OpenSBI should be compiled for sifive platform with following =
additional=20
>>>> argument
>>>>=20
>>>> FW_PAYLOAD_FDT_PATH=3D<linux kernel=20
>>>> source>/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dtb
>>>>=20
>>>> FYI: It will only work when kernel is given a payload to =
U-Boot/OpenSBI=20
>>>> directly.
>>>>=20
>>>=20
>>> Hum, I am surprised by this statement.
>>> I was able to verify the latest DT patch serie from Paul with:
>>> OpenSBI + U-Boot + Linux & DT.
>>>=20
>>> Following the OpenSBI documentation [0] with U-Boot payload:
>>> FW_PAYLOAD_PATH=3D<u-boot_build_dir>/u-boot.bin
>>>=20
>>> I get an U-Boot prompt and then I can just load the linux kernel and
>>> device tree from the network.
>>>=20
>>> [0]: =
https://github.com/riscv/opensbi/blob/master/docs/platform/sifive_fu540.md=
#building-sifive-fu540-platform
>>>=20
>>=20
>> Could you confirm which git hash of U-boot you are building, and that =
the .config matches
>> the defconfig (or send me the .config you used)?
>=20
> Sure,
>=20
> OpenSBI: a6395acd6cb2c35871481d3e4f0beaf449f8c0fd
> U-Boot: (origin/master) 344a0e4367d0820b8eb2ea4a90132433e038095f
> Kernel: from Paul from this thread [1]
>=20
> I use the sifive_fu540_defconfig of U-Boot with no additional changes.
>=20
> [1] =
https://github.com/sifive/riscv-linux/tree/dev/paulw/dts-v5.2-rc1-experime=
ntal
>=20
>>=20
>> I=E2=80=99d like to get everything that=E2=80=99s working integrated =
in one place into a freedom-u-sdk test branch.
>>=20
>>=20
>=20
> Let me know the test branch when it's up :)
>=20
> Loys

Please take a look at =
https://github.com/tmagik/freedom-u-sdk/tree/functional_test

When I booted the original 4.19 vmlinux.bin, I got this:

Booting kernel in
2
1
0
## Starting application at 0x80200000 ...
[    0.000000] Linux version 4.19.0-sifive-1+ (troyb@epsilon09) (gcc =
version 8.3.0 (Buildroot 29
[    0.000000] bootconsole [early0] enabled

With the 5.2 kernel, I get know output, which I assume is expected =
behavior using the
current DTS provided by the S-mode Uboot.

Booting kernel in
2
1
0
## Starting application at 0x80200000 ...=