Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4671625ybi; Mon, 3 Jun 2019 15:14:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0z1SqI0vb3nhbw+cSPp1n5W6rMpQYleUrIQDhW3dBtefQ1gowT57yg5DR9EzJzwLNir6K X-Received: by 2002:a17:902:bd06:: with SMTP id p6mr32373691pls.112.1559600061159; Mon, 03 Jun 2019 15:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559600061; cv=none; d=google.com; s=arc-20160816; b=Wp1IGWjVtAXFpb0WshkbcD/1MCOrp3JPiL2XEqscwvKXDlavBJFpBvSKHmv096Ti/c S0+bQpdK5LXUwUqjiutgpIGZhl3u99crYfR6Z6Fe6mod2956e285Zrt3e4Ptm7kH3WmV 8f36QzZtJ06sNn49DAc0UvpCbtK2CLYCIXSIDyCArz6kO2E+1Z5gfok8o/w/tFSVtYBu Q3vcKvIQ2yUqdN1tvff6JeeBLU+ccJJikBjuwvUEgMToRfm3DzneNhzKUtkZpmT2aKSF kOfgDnsMdLFObsZtrvXv80+bq6M5Lzb+QP8vvnWlICnuIt008/y9iqsxj+n9I+YRbWJD APqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=km58fABTt3DIpuAzCpSdr6Gk73zyXfjiV+KecEnasTs=; b=vQ2A8f7VpnMGNXpq94Rwjg1KnLdM1mPojN7jswrN+IZBv/iYpFqb6swnSCQWLM0/q9 Q1VwsmEtuujrOUnNqV5xU6olp+XyxWSfnmNoMl5pPUEFHmcifReah82GvJKJ5i+6X1GA H70kgiFgj5IQFSy6Y6ha6xdBdgbbih48M/A6QJy0723VvjhwP60U5XcKkUdsqdyOMa/0 urzqNwWiUCjFhQvj31js5bgw9QjFHdgHMvL8m5izkk0uOIlMsftIv3PHdO5k0Lj7XeuP W9ojCHD8R2Fd6W+7kgsiWZLCgOQHKpkvUcltghtmI6X2Qoc0GQbFfO0Hqp8WLsRmyQ68 pGwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si5578238pgj.171.2019.06.03.15.14.04; Mon, 03 Jun 2019 15:14:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726870AbfFCWLV (ORCPT + 99 others); Mon, 3 Jun 2019 18:11:21 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfFCWLV (ORCPT ); Mon, 3 Jun 2019 18:11:21 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AD5D5136E16B0; Mon, 3 Jun 2019 15:11:20 -0700 (PDT) Date: Mon, 03 Jun 2019 15:11:20 -0700 (PDT) Message-Id: <20190603.151120.958835957071709710.davem@davemloft.net> To: yuehaibing@huawei.com Cc: gregkh@linuxfoundation.org, tglx@linutronix.de, ariel.elior@marvell.com, michal.kalderon@marvell.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK From: David Miller In-Reply-To: <20190601080605.13052-1-yuehaibing@huawei.com> References: <20190601080605.13052-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Jun 2019 15:11:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Sat, 1 Jun 2019 16:06:05 +0800 > Fix gcc build error while CONFIG_DEVLINK is not set > > drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove': > qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister' > > Select DEVLINK to fix this. > > Reported-by: Hulk Robot > Fixes: 24e04879abdd ("qed: Add qed devlink parameters table") > Signed-off-by: YueHaibing Applied.