Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4673506ybi; Mon, 3 Jun 2019 15:16:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxA81TeEUKyZH6VpV0rF8njUBSRpVuB0lUeNHWq2fIjuB4R/NnPizMur86uAopfaf9HWkvB X-Received: by 2002:a17:90a:bf84:: with SMTP id d4mr32389634pjs.124.1559600205818; Mon, 03 Jun 2019 15:16:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559600205; cv=none; d=google.com; s=arc-20160816; b=UvXU1l6rvJeHe77j0zilOnjADMf7rtL/ryCPpT+P1t+9411UfPvYypA5Ju99e5xGPo HxKJ855ozYHvzNIk+5sqw3IV/AIvKuOLG+sZskMco/wX36kM0k6m7vNv944nLDudjYZF 80gj6RQ0Lr3+TIQKEvo+XBsQ9bCm7CdjOjV+ZcWfRfJ+Qb2vKqsbY1j7k0OO/3khWjxz D2XnCpQFAuV7fQ2FjG5/1164q4nYqG2FQ/vhgkkgcxuQynMRWZAdI9nboQ+rS2w/XNic S60McIhFs2vF3gOF1Gkh1ljnvVla5Jx+lS/Gvsm2Adc1SuIaMY8ZNH1qMsUrcRAMSljc a/dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XrXElNBSjlaaqdNNjzvuo71sigsV1d5pDtZBpRqJEHE=; b=E0QY+M8NlPCyI1EBbNCC9yA/+ocbfa8n1Dc3kU/Erk71Ojrcdm75VWIil3vMbWfNQ5 diPIFE7YMWt6MDn0QvOTNGgVbutHWl4pWm/HVmPJ+P4TZG18BCS1RoGXn0ykZDm/Adkg 1l5iPoP6U0m2wyovWGTFmCSA1v+jjQg+5ff22N43mszvGeDeZNEcU/3aGrJ829mECXGC tFT8odgjdyUj8BHWIkOivp/4P+WGSu+s6iOm1jT/8J7D0amh+H1jh8nl2xfoQCzraa1n AHkrghoGL0B7lguA9VnB8TZNTEL7OvNPPHmE4IUcIodku2W6bzOEV+DVgIA6GV0gn8yQ bvZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r63si1777943plb.5.2019.06.03.15.16.29; Mon, 03 Jun 2019 15:16:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbfFCWOA (ORCPT + 99 others); Mon, 3 Jun 2019 18:14:00 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47385 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfFCWN7 (ORCPT ); Mon, 3 Jun 2019 18:13:59 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id BF51A802AA; Tue, 4 Jun 2019 00:13:46 +0200 (CEST) Date: Tue, 4 Jun 2019 00:13:56 +0200 From: Pavel Machek To: Enric Balletbo i Serra Cc: Nick Crews , bleung@chromium.org, linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, linux-kernel@vger.kernel.org, dlaurie@chromium.org, sjg@google.com, groeck@google.com, dtor@google.com Subject: Re: [PATCH v6] platform/chrome: Add Wilco EC keyboard backlight LEDs support Message-ID: <20190603221356.GA20392@amd> References: <20190409001642.249197-1-ncrews@chromium.org> <20190409095503.GB32344@atrey.karlin.mff.cuni.cz> <66bafd50-1599-db70-99da-e7f5877281c2@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <66bafd50-1599-db70-99da-e7f5877281c2@collabora.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > On 9/4/19 11:55, Pavel Machek wrote: > >> The EC is in charge of controlling the keyboard backlight on > >> the Wilco platform. We expose a standard LED class device at > >> /sys/class/leds/chromeos::kbd_backlight. This driver is modeled > >=20 > > As discussed, please use platform::. > >=20 >=20 > Last time I looked at this patch there were some work and discussion ongo= ing > about led naming in led ML, did the discussion end? I'm not able to find = if > there is a final agreement. Jacek is working on series to clean up naming, yes. Under new naming system, it should be "/sys/class/leds/color:kbd_backlight", AFAICT. That is acceptable to me. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --azLHFNyN32YCQGCU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlz1m6QACgkQMOfwapXb+vJ5LwCgpek5SXHzggCsQQ2ueC/e0eSG 2R0An3py0o6dk8ItqDWaq+E99cUrXv68 =AtT6 -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--